Skip to content
Snippets Groups Projects

Add directional weights to smoothness constraint

Merged Andre Offringa requested to merge add-directional-weights into master
All threads resolved!

This is step one of two to enable weighting the smoothing by the model data.

Merge request reports

Merge request pipeline #98096 passed

Merge request pipeline passed for 520fdc27

Test coverage 77.00% (0.00%) from 1 job
Approved by

Merged by Andre OffringaAndre Offringa 1 month ago (Nov 14, 2024 2:25pm UTC)

Merge details

  • Changes merged into master with 3ad7ca2d (commits were squashed).
  • Deleted the source branch.

Pipeline #98099 passed

Pipeline passed for 3ad7ca2d on master

Test coverage 77.00% (0.00%) from 1 job

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
    • Resolved by Tammo Jan Dijkema

      Would it be better to put the weights_per_direction in the top level Constraint? Not sure myself, the mechanism there should be generic enough to support weights per direction (the docs in Constraint.h say Both vals and weights have the dimensions described in dims and axes., I'm not sure if that is still true).

  • Andre Offringa resolved all threads

    resolved all threads

  • Andre Offringa added 1 commit

    added 1 commit

    • 5aa9895f - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Andre Offringa added 1 commit

    added 1 commit

    • cdbb52e1 - Place new function in Constraint

    Compare with previous version

  • Andre Offringa added 1 commit

    added 1 commit

    Compare with previous version

  • Andre Offringa requested review from @dijkema

    requested review from @dijkema

  • Andre Offringa added 15 commits

    added 15 commits

    Compare with previous version

  • Tammo Jan Dijkema resolved all threads

    resolved all threads

  • Tammo Jan Dijkema approved this merge request

    approved this merge request

  • Andre Offringa mentioned in commit 3ad7ca2d

    mentioned in commit 3ad7ca2d

  • Please register or sign in to reply
    Loading