From db9bc34bdc58133b0fb7f635a3549d210395c124 Mon Sep 17 00:00:00 2001
From: Eric Kooistra <kooistra@astron.nl>
Date: Wed, 14 Feb 2024 13:42:49 +0100
Subject: [PATCH] Remove note on Quartus segmentation error. Explain
 c_sdp_bdo_reorder_nof_blocks_max = 4 and nof_bdo_destinations_max = 8.

---
 .../lofar2/libraries/sdp/src/vhdl/sdp_bdo_pkg.vhd         | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/applications/lofar2/libraries/sdp/src/vhdl/sdp_bdo_pkg.vhd b/applications/lofar2/libraries/sdp/src/vhdl/sdp_bdo_pkg.vhd
index 33df8e23bc..d19cf03a6b 100644
--- a/applications/lofar2/libraries/sdp/src/vhdl/sdp_bdo_pkg.vhd
+++ b/applications/lofar2/libraries/sdp/src/vhdl/sdp_bdo_pkg.vhd
@@ -59,16 +59,12 @@ package sdp_bdo_pkg is
   -- nof_destinations > 1 and how many block RAM resources are available for
   -- the reordering. Therefore c_sdp_bdo_reorder_nof_blocks_max = 16 is a
   -- suitable compromise value.
-  -- Conclusion:
+  -- Conclusion (14 feb 2024):
   -- . Choose c_sdp_bdo_reorder_nof_blocks_max = 4 to save block RAM resources,
   --   and because it is acceptable to have smaller packets in case of more
   --   than 4 destinations. Note that the reorder buffer is dual page.
   -- . Choose nof_bdo_destinations_max = 8 in design revision, because it is
-  --   enough for CEP and to save logic resources and to ease timing closure.
-  -- Remark:
-  -- . The c_sdp_bdo_reorder_nof_blocks_max must be <=
-  --   nof_bdo_destinations_max, because otherwise this probably caused
-  --   Quartus synthesis to yield an segmentation error.
+  --   enough for CEP, and to save logic resources and to ease timing closure.
   constant c_sdp_bdo_reorder_nof_blocks_max : natural := 4;
   constant c_sdp_bdo_reorder_nof_blocks_w   : natural := ceil_log2(c_sdp_bdo_reorder_nof_blocks_max + 1);
   constant c_sdp_bdo_reorder_nof_ch_max     : natural := c_sdp_bdo_reorder_nof_blocks_max *
-- 
GitLab