From 9fb1de8870cb064eb59fa5d199b00a5a6ead93aa Mon Sep 17 00:00:00 2001
From: Reinier van der Walle <walle@astron.nl>
Date: Tue, 20 Jul 2021 17:16:05 +0200
Subject: [PATCH] processed review comments

---
 libraries/base/dp/tb/vhdl/tb_dp_block_validate_channel.vhd | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/libraries/base/dp/tb/vhdl/tb_dp_block_validate_channel.vhd b/libraries/base/dp/tb/vhdl/tb_dp_block_validate_channel.vhd
index 0319f451dd..a1ec945686 100644
--- a/libraries/base/dp/tb/vhdl/tb_dp_block_validate_channel.vhd
+++ b/libraries/base/dp/tb/vhdl/tb_dp_block_validate_channel.vhd
@@ -25,7 +25,6 @@
 -- Test bench for dp_block_validate_channel.
 -- Description:
 -- Verifies the output sosi of the DUT with the expected sosi. 
--- The TB also reads the register values via MM and verifies them against the 
 -- expected values.  
 -- Usage:
 -- . as 5
@@ -157,31 +156,37 @@ BEGIN
           ASSERT keep_sosi.valid = '0'        REPORT "Wrong, removed block occurs in keep_sosi!" SEVERITY ERROR; 
           ASSERT keep_sosi.sop   = '0'        REPORT "Wrong, removed block occurs in keep_sosi!" SEVERITY ERROR; 
           ASSERT keep_sosi.eop   = '0'        REPORT "Wrong, removed block occurs in keep_sosi!" SEVERITY ERROR; 
+          ASSERT keep_sosi.sync  = '0'        REPORT "Wrong, removed block occurs in keep_sosi!" SEVERITY ERROR; 
         ELSIF g_mode = "=" THEN
           ASSERT keep_sosi = reference_sosi   REPORT "No block in keep_sosi" SEVERITY ERROR;
           ASSERT remove_sosi.valid = '0'      REPORT "Wrong, block occurs in remove_sosi which is unexpected!" SEVERITY ERROR; 
           ASSERT remove_sosi.sop   = '0'      REPORT "Wrong, block occurs in remove_sosi which is unexpected!" SEVERITY ERROR; 
           ASSERT remove_sosi.eop   = '0'      REPORT "Wrong, block occurs in remove_sosi which is unexpected!" SEVERITY ERROR;
+          ASSERT remove_sosi.sync  = '0'      REPORT "Wrong, block occurs in remove_sosi which is unexpected!" SEVERITY ERROR;
         ELSIF TO_UINT(reference_sosi.channel) < g_remove_channel AND g_mode = "<" THEN
           ASSERT remove_sosi = reference_sosi REPORT "remove_sosi does not contain removed block!" SEVERITY ERROR;
           ASSERT keep_sosi.valid = '0'        REPORT "Wrong, removed block occurs in keep_sosi!" SEVERITY ERROR; 
           ASSERT keep_sosi.sop   = '0'        REPORT "Wrong, removed block occurs in keep_sosi!" SEVERITY ERROR; 
           ASSERT keep_sosi.eop   = '0'        REPORT "Wrong, removed block occurs in keep_sosi!" SEVERITY ERROR; 
+          ASSERT keep_sosi.sync  = '0'        REPORT "Wrong, removed block occurs in keep_sosi!" SEVERITY ERROR; 
         ELSIF g_mode = "<" THEN
           ASSERT keep_sosi = reference_sosi   REPORT "No block in keep_sosi" SEVERITY ERROR;
           ASSERT remove_sosi.valid = '0'      REPORT "Wrong, block occurs in remove_sosi which is unexpected!" SEVERITY ERROR; 
           ASSERT remove_sosi.sop   = '0'      REPORT "Wrong, block occurs in remove_sosi which is unexpected!" SEVERITY ERROR; 
           ASSERT remove_sosi.eop   = '0'      REPORT "Wrong, block occurs in remove_sosi which is unexpected!" SEVERITY ERROR;
+          ASSERT remove_sosi.sync  = '0'      REPORT "Wrong, block occurs in remove_sosi which is unexpected!" SEVERITY ERROR;
         ELSIF TO_UINT(reference_sosi.channel) > g_remove_channel AND g_mode = ">" THEN
           ASSERT remove_sosi = reference_sosi REPORT "remove_sosi does not contain removed block!" SEVERITY ERROR;
           ASSERT keep_sosi.valid = '0'        REPORT "Wrong, removed block occurs in keep_sosi!" SEVERITY ERROR; 
           ASSERT keep_sosi.sop   = '0'        REPORT "Wrong, removed block occurs in keep_sosi!" SEVERITY ERROR; 
           ASSERT keep_sosi.eop   = '0'        REPORT "Wrong, removed block occurs in keep_sosi!" SEVERITY ERROR; 
+          ASSERT keep_sosi.sync  = '0'        REPORT "Wrong, removed block occurs in keep_sosi!" SEVERITY ERROR; 
         ELSIF g_mode = ">" THEN
           ASSERT keep_sosi = reference_sosi   REPORT "No block in keep_sosi" SEVERITY ERROR;
           ASSERT remove_sosi.valid = '0'      REPORT "Wrong, block occurs in remove_sosi which is unexpected!" SEVERITY ERROR; 
           ASSERT remove_sosi.sop   = '0'      REPORT "Wrong, block occurs in remove_sosi which is unexpected!" SEVERITY ERROR; 
           ASSERT remove_sosi.eop   = '0'      REPORT "Wrong, block occurs in remove_sosi which is unexpected!" SEVERITY ERROR;
+          ASSERT remove_sosi.sync  = '0'      REPORT "Wrong, block occurs in remove_sosi which is unexpected!" SEVERITY ERROR;
         END IF;
       END IF;
     END IF;
-- 
GitLab