From 6b22cf7a6d82c3d93f8d2a8fd793d07ebcc2b30e Mon Sep 17 00:00:00 2001
From: Eric Kooistra <kooistra@astron.nl>
Date: Fri, 4 Mar 2022 12:13:15 +0100
Subject: [PATCH] Use c_sdp_wpfb_fir_filter_dc_gain from sdp_pkg.vhd.

---
 .../tb_lofar2_unb2c_sdp_station_bf.vhd                 | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/applications/lofar2/designs/lofar2_unb2c_sdp_station/revisions/lofar2_unb2c_sdp_station_bf/tb_lofar2_unb2c_sdp_station_bf.vhd b/applications/lofar2/designs/lofar2_unb2c_sdp_station/revisions/lofar2_unb2c_sdp_station_bf/tb_lofar2_unb2c_sdp_station_bf.vhd
index 2571232691..7bcf835fb5 100644
--- a/applications/lofar2/designs/lofar2_unb2c_sdp_station/revisions/lofar2_unb2c_sdp_station_bf/tb_lofar2_unb2c_sdp_station_bf.vhd
+++ b/applications/lofar2/designs/lofar2_unb2c_sdp_station/revisions/lofar2_unb2c_sdp_station_bf/tb_lofar2_unb2c_sdp_station_bf.vhd
@@ -173,7 +173,7 @@ ARCHITECTURE tb OF tb_lofar2_unb2c_sdp_station_bf IS
   CONSTANT c_subband_phase_offset           : REAL := -90.0;  -- WG with zero phase sinues yields subband with -90 degrees phase (negative Im, zero Re)
   CONSTANT c_subband_weight_gain            : REAL := 1.0;  -- use default unit subband weights
   CONSTANT c_subband_weight_phase           : REAL := 0.0;  -- use default unit subband weights
-  CONSTANT c_exp_subband_sp_ampl_ratio      : REAL := 7.96;  -- ~= 8 for unit FIR DC gain, depends on internal WPFB quantization and FIR coefficients
+  CONSTANT c_exp_subband_sp_ampl_ratio      : REAL := 8.0 * c_sdp_wpfb_fir_filter_dc_gain;  -- ~= 8 for unit FIR DC gain, depends on internal WPFB quantization and FIR coefficients
   CONSTANT c_exp_subband_ampl               : REAL := REAL(c_wg_ampl) * c_exp_subband_sp_ampl_ratio * c_subband_weight_gain;
   CONSTANT c_exp_subband_power              : REAL := c_exp_subband_ampl**2.0;  -- complex, so no divide by 2
   CONSTANT c_exp_subband_sst                : REAL := c_exp_subband_power * REAL(c_nof_block_per_sync);
@@ -207,11 +207,11 @@ ARCHITECTURE tb OF tb_lofar2_unb2c_sdp_station_bf IS
   --   . c_sdp_S_pn = 12 instances
   CONSTANT c_addr_w_reg_diag_wg     : NATURAL := 2;
   --   . c_sdp_N_beamsets = 2 instances
-  CONSTANT c_addr_w_ram_ss_ss_wide : NATURAL := ceil_log2(c_sdp_P_pfb * c_sdp_S_sub_bf * c_sdp_Q_fft);
+  CONSTANT c_addr_w_ram_ss_ss_wide  : NATURAL := ceil_log2(c_sdp_P_pfb * c_sdp_S_sub_bf * c_sdp_Q_fft);
   CONSTANT c_addr_w_ram_bf_weights  : NATURAL := ceil_log2(c_sdp_N_pol_bf * c_sdp_P_pfb * c_sdp_S_sub_bf * c_sdp_Q_fft);
-  CONSTANT c_addr_w_reg_bf_scale   : NATURAL := 1;
-  CONSTANT c_addr_w_reg_hdr_dat    : NATURAL := ceil_log2(field_nof_words(c_sdp_cep_hdr_field_arr, c_word_w));
-  CONSTANT c_addr_w_reg_dp_xonoff  : NATURAL := 1;
+  CONSTANT c_addr_w_reg_bf_scale    : NATURAL := 1;
+  CONSTANT c_addr_w_reg_hdr_dat     : NATURAL := ceil_log2(field_nof_words(c_sdp_cep_hdr_field_arr, c_word_w));
+  CONSTANT c_addr_w_reg_dp_xonoff   : NATURAL := 1;
   CONSTANT c_addr_w_ram_st_bst      : NATURAL := ceil_log2(c_sdp_S_sub_bf*c_sdp_N_pol_bf*c_stat_data_sz);
   -- . Address spans of a single MM instance
   --   . c_sdp_S_pn = 12 instances
-- 
GitLab