From 552554f49a5f59f6cbe088c6b7a3f654aa1fc98d Mon Sep 17 00:00:00 2001
From: Reinier van der Walle <walle@astron.nl>
Date: Mon, 7 Feb 2022 09:03:07 +0100
Subject: [PATCH] processed review comments
---
.../src/vhdl/lofar2_unb2c_sdp_station.vhd | 1 +
.../lofar2/libraries/sdp/src/vhdl/node_sdp_correlator.vhd | 4 ++--
libraries/base/dp/dp.peripheral.yaml | 2 +-
libraries/base/dp/src/vhdl/dp_repack_data.vhd | 2 +-
4 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/applications/lofar2/designs/lofar2_unb2c_sdp_station/src/vhdl/lofar2_unb2c_sdp_station.vhd b/applications/lofar2/designs/lofar2_unb2c_sdp_station/src/vhdl/lofar2_unb2c_sdp_station.vhd
index 4c28ed7ae9..d2e63d498c 100644
--- a/applications/lofar2/designs/lofar2_unb2c_sdp_station/src/vhdl/lofar2_unb2c_sdp_station.vhd
+++ b/applications/lofar2/designs/lofar2_unb2c_sdp_station/src/vhdl/lofar2_unb2c_sdp_station.vhd
@@ -720,6 +720,7 @@ BEGIN
g_use_fsub => c_revision_select.use_fsub,
g_use_xsub => c_revision_select.use_xsub,
g_use_bf => c_revision_select.use_bf,
+ g_use_ring => c_revision_select.use_ring,
g_P_sq => c_revision_select.P_sq
)
PORT MAP (
diff --git a/applications/lofar2/libraries/sdp/src/vhdl/node_sdp_correlator.vhd b/applications/lofar2/libraries/sdp/src/vhdl/node_sdp_correlator.vhd
index b9be6be95e..65ff3452cc 100644
--- a/applications/lofar2/libraries/sdp/src/vhdl/node_sdp_correlator.vhd
+++ b/applications/lofar2/libraries/sdp/src/vhdl/node_sdp_correlator.vhd
@@ -194,7 +194,7 @@ BEGIN
g_in_nof_words => c_longword_w/c_data_w,
g_out_dat_w => c_longword_w,
g_out_nof_words => 1,
- g_pipeline_ready => TRUE
+ g_pipeline_ready => TRUE -- Needed for src_in.ready to snk_out.ready.
)
PORT MAP (
rst => dp_rst,
@@ -236,7 +236,7 @@ BEGIN
g_in_nof_words => 1,
g_out_dat_w => c_data_w,
g_out_nof_words => c_longword_w/c_data_w,
- g_pipeline_ready => TRUE
+ g_pipeline_ready => TRUE -- Needed for src_in.ready to snk_out.ready.
)
PORT MAP (
rst => dp_rst,
diff --git a/libraries/base/dp/dp.peripheral.yaml b/libraries/base/dp/dp.peripheral.yaml
index d420277f5b..bb68ec6542 100644
--- a/libraries/base/dp/dp.peripheral.yaml
+++ b/libraries/base/dp/dp.peripheral.yaml
@@ -120,7 +120,7 @@ peripherals:
number_of_mm_ports: g_nof_streams
fields:
- - field_name: enable
- field_description: "Stream enable"
+ field_description: "Stream enable per stream via bits g_nof_streams-1 : 0. Bit value 0 disables the stream, 1 enables the stream. Disabled streams are not aligned."
address_offset: 0x0
mm_width: 1
access_mode: RW
diff --git a/libraries/base/dp/src/vhdl/dp_repack_data.vhd b/libraries/base/dp/src/vhdl/dp_repack_data.vhd
index 7d777a1eb8..d1c86bf258 100644
--- a/libraries/base/dp/src/vhdl/dp_repack_data.vhd
+++ b/libraries/base/dp/src/vhdl/dp_repack_data.vhd
@@ -650,7 +650,7 @@ ENTITY dp_repack_data IS
g_out_dat_w : NATURAL;
g_out_nof_words : NATURAL;
g_out_symbol_w : NATURAL := 1; -- default 1 for src_out.empty in nof bits, else use power of 2
- g_pipeline_ready : BOOLEAN := FALSE
+ g_pipeline_ready : BOOLEAN := FALSE -- TRUE to pipeline ready from src_in to snk_out.
);
PORT (
rst : IN STD_LOGIC;
--
GitLab