From 4d54653d50e746e913906be2be23848007dbcc63 Mon Sep 17 00:00:00 2001
From: Eric Kooistra <kooistra@astron.nl>
Date: Thu, 3 Mar 2022 10:39:15 +0100
Subject: [PATCH] XSub and BF use in_sosi_arr = fsub_sosi_arr, so weighted
 subbands for the statistics.

---
 .../lofar2/libraries/sdp/src/vhdl/node_sdp_beamformer.vhd     | 3 ++-
 .../lofar2/libraries/sdp/src/vhdl/node_sdp_correlator.vhd     | 1 +
 applications/lofar2/libraries/sdp/src/vhdl/sdp_station.vhd    | 4 ++--
 3 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/applications/lofar2/libraries/sdp/src/vhdl/node_sdp_beamformer.vhd b/applications/lofar2/libraries/sdp/src/vhdl/node_sdp_beamformer.vhd
index c82f450ad9..e2152de22a 100644
--- a/applications/lofar2/libraries/sdp/src/vhdl/node_sdp_beamformer.vhd
+++ b/applications/lofar2/libraries/sdp/src/vhdl/node_sdp_beamformer.vhd
@@ -310,8 +310,9 @@ BEGIN
     udp_src_port => stat_udp_src_port,
     ip_src_addr  => stat_ip_src_addr,
 
+    gn_index     => TO_UINT(gn_id),
     sdp_info     => sdp_info,
-    gn_index     => TO_UINT(gn_id)
+    weighted_subbands_flag => '1'  -- because BF uses in_sosi_arr = fsub_sosi_arr, so weighted subbands
   );
 
   ---------------------------------------------------------------
diff --git a/applications/lofar2/libraries/sdp/src/vhdl/node_sdp_correlator.vhd b/applications/lofar2/libraries/sdp/src/vhdl/node_sdp_correlator.vhd
index 03f7153082..f692703f72 100644
--- a/applications/lofar2/libraries/sdp/src/vhdl/node_sdp_correlator.vhd
+++ b/applications/lofar2/libraries/sdp/src/vhdl/node_sdp_correlator.vhd
@@ -468,6 +468,7 @@ BEGIN
     gn_index       => TO_UINT(gn_id),
     ring_info      => ring_info,
     sdp_info       => sdp_info,
+    weighted_subbands_flag  => '1',  -- because XSub uses in_sosi_arr = fsub_sosi_arr, so weighted subbands
     nof_crosslets  => nof_crosslets,
     crosslets_info => crosslets_info
   );
diff --git a/applications/lofar2/libraries/sdp/src/vhdl/sdp_station.vhd b/applications/lofar2/libraries/sdp/src/vhdl/sdp_station.vhd
index 36ab5c31f8..8aaa60d406 100644
--- a/applications/lofar2/libraries/sdp/src/vhdl/sdp_station.vhd
+++ b/applications/lofar2/libraries/sdp/src/vhdl/sdp_station.vhd
@@ -403,8 +403,8 @@ ARCHITECTURE str OF sdp_station IS
   ----------------------------------------------
 
   SIGNAL ait_sosi_arr                      : t_dp_sosi_arr(c_sdp_S_pn-1 DOWNTO 0);         
-  SIGNAL pfb_sosi_arr                      : t_dp_sosi_arr(c_sdp_P_pfb-1 DOWNTO 0);         
-  SIGNAL fsub_sosi_arr                     : t_dp_sosi_arr(c_sdp_P_pfb-1 DOWNTO 0);        
+  SIGNAL pfb_sosi_arr                      : t_dp_sosi_arr(c_sdp_P_pfb-1 DOWNTO 0);  -- raw subbands
+  SIGNAL fsub_sosi_arr                     : t_dp_sosi_arr(c_sdp_P_pfb-1 DOWNTO 0);  -- weighted subbands
   SIGNAL bs_sosi                           : t_dp_sosi;        
  
   SIGNAL xst_from_ri_sosi                  : t_dp_sosi;        
-- 
GitLab