From 33a713a5ed70e5884d35ae6b6f00f584cedf51e8 Mon Sep 17 00:00:00 2001
From: Eric Kooistra <kooistra@astron.nl>
Date: Tue, 29 Aug 2023 11:58:01 +0200
Subject: [PATCH] Use g_fifo_note_is_ful for FIFOs.

---
 libraries/base/dp/src/vhdl/dp_block_validate_err.vhd | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/libraries/base/dp/src/vhdl/dp_block_validate_err.vhd b/libraries/base/dp/src/vhdl/dp_block_validate_err.vhd
index 3677ae36db..ed166c70dd 100644
--- a/libraries/base/dp/src/vhdl/dp_block_validate_err.vhd
+++ b/libraries/base/dp/src/vhdl/dp_block_validate_err.vhd
@@ -120,7 +120,8 @@ entity dp_block_validate_err is
 end dp_block_validate_err;
 
 architecture rtl of dp_block_validate_err is
-  constant c_nof_err_ok : natural := ceil_div(g_max_block_size, g_min_block_size);
+  -- use +1 margin for c_nof_err_ok
+  constant c_nof_err_ok : natural := ceil_div(g_max_block_size, g_min_block_size) + 1;
   constant c_nof_regs   : natural := g_nof_err_counts + 1 + 2 + 1;
   constant c_clear_adr  : natural := c_nof_regs - 1;
 
@@ -293,7 +294,7 @@ begin
     out_reg     => open  -- no write
   );
 
-  u_fifo_fill_eop : entity work.dp_fifo_fill_eop_sc
+  u_fifo_fill_eop_sc : entity work.dp_fifo_fill_eop_sc
   generic map (
     g_note_is_ful  => g_fifo_note_is_ful,
     g_data_w       => g_data_w,
@@ -349,6 +350,7 @@ begin
 
   u_fifo_err_ok : entity common_lib.common_fifo_sc
   generic map (
+    g_note_is_ful => g_fifo_note_is_ful,
     g_dat_w => 1,
     g_nof_words => c_nof_err_ok
   )
-- 
GitLab