From 04b9628bf588c193ebfffedc819bb2e05c3d561b Mon Sep 17 00:00:00 2001
From: Eric Kooistra <kooistra@astron.nl>
Date: Tue, 24 Jan 2023 20:12:49 +0100
Subject: [PATCH] Do not enable BST offload, because MM accesses interfer with
MP read accesses via c_mm_file_ram_st_bst.
---
.../tb_lofar2_unb2c_sdp_station_bf.vhd | 7 +++++--
.../tb_lofar2_unb2c_sdp_station_bf_ring.vhd | 7 +++++--
2 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/applications/lofar2/designs/lofar2_unb2c_sdp_station/revisions/lofar2_unb2c_sdp_station_bf/tb_lofar2_unb2c_sdp_station_bf.vhd b/applications/lofar2/designs/lofar2_unb2c_sdp_station/revisions/lofar2_unb2c_sdp_station_bf/tb_lofar2_unb2c_sdp_station_bf.vhd
index 3a05229ad5..ac15cb3b8e 100644
--- a/applications/lofar2/designs/lofar2_unb2c_sdp_station/revisions/lofar2_unb2c_sdp_station_bf/tb_lofar2_unb2c_sdp_station_bf.vhd
+++ b/applications/lofar2/designs/lofar2_unb2c_sdp_station/revisions/lofar2_unb2c_sdp_station_bf/tb_lofar2_unb2c_sdp_station_bf.vhd
@@ -820,8 +820,11 @@ BEGIN
----------------------------------------------------------------------------
-- Enable BST offload (not verified here, but only for view in Wave window)
----------------------------------------------------------------------------
- v_offset := bset * c_mm_span_reg_stat_enable_bst;
- mmf_mm_bus_wr(c_mm_file_reg_stat_enable_bst, v_offset + 0, 1, tb_clk);
+
+ -- Do not enable BST offload, because MM accesses interfer with MP read
+ -- accesses via c_mm_file_ram_st_bst, and causes incorrects BST values.
+ --v_offset := bset * c_mm_span_reg_stat_enable_bst;
+ --mmf_mm_bus_wr(c_mm_file_reg_stat_enable_bst, v_offset + 0, 1, tb_clk);
----------------------------------------------------------------------------
-- Enable beamlet output (dp_xonoff)
diff --git a/applications/lofar2/designs/lofar2_unb2c_sdp_station/revisions/lofar2_unb2c_sdp_station_bf_ring/tb_lofar2_unb2c_sdp_station_bf_ring.vhd b/applications/lofar2/designs/lofar2_unb2c_sdp_station/revisions/lofar2_unb2c_sdp_station_bf_ring/tb_lofar2_unb2c_sdp_station_bf_ring.vhd
index ae3d8b5d29..359da63847 100644
--- a/applications/lofar2/designs/lofar2_unb2c_sdp_station/revisions/lofar2_unb2c_sdp_station_bf_ring/tb_lofar2_unb2c_sdp_station_bf_ring.vhd
+++ b/applications/lofar2/designs/lofar2_unb2c_sdp_station/revisions/lofar2_unb2c_sdp_station_bf_ring/tb_lofar2_unb2c_sdp_station_bf_ring.vhd
@@ -878,8 +878,11 @@ BEGIN
----------------------------------------------------------------------------
-- Enable BST offload on last node (not verified here, but only for view in Wave window)
----------------------------------------------------------------------------
- v_offset := bset * c_mm_span_reg_stat_enable_bst;
- mmf_mm_bus_wr(c_mm_file_reg_stat_enable_bst, v_offset + 0, 1, tb_clk);
+
+ -- Do not enable BST offload, because MM accesses interfer with MP read
+ -- accesses via c_mm_file_ram_st_bst, and causes incorrects BST values.
+ --v_offset := bset * c_mm_span_reg_stat_enable_bst;
+ --mmf_mm_bus_wr(c_mm_file_reg_stat_enable_bst, v_offset + 0, 1, tb_clk);
----------------------------------------------------------------------------
-- Enable beamlet output on last node (dp_xonoff)
--
GitLab