From 5d789762fbb10e0cfdac4816b5d08986edef4657 Mon Sep 17 00:00:00 2001
From: Eric Kooistra <kooistra@astron.nl>
Date: Wed, 19 Oct 2022 14:23:47 +0200
Subject: [PATCH] Defined default FIR coefficients order.

---
 matlab/one_pfb.m | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/matlab/one_pfb.m b/matlab/one_pfb.m
index d759b7b..c8838d9 100644
--- a/matlab/one_pfb.m
+++ b/matlab/one_pfb.m
@@ -85,7 +85,10 @@
 %   (tb.nof_subbands).
 %
 % * Flipped order of FIR coefficients:
-%   The FIR coefficients in the PFB are flipped per column of N_fft = 1024
+%   The FIR filter in the PFB is defined by a prototype filter h[] with N_fft
+%   * N_taps = 1024 *16 = 16384 coefficients. The impulse response of this
+%   prototype filter will show the coefficients in h[0:16383] order. The
+%   FIR coefficients of h[] in the PFB are flipped per column of N_fft = 1024
 %   coefficients, for all N_taps = 16 columns. In VHDL simulation this shows
 %   with tb_verify_pfb_response.vhd and in the Matlab model this flip is also
 %   done by ctrl_pfir_subband.coeff = flipud(ctrl_pfir_subband.coeff).
-- 
GitLab