From d76e9d39699c6f02603f8acbdd888787e251271e Mon Sep 17 00:00:00 2001 From: Jorrit Schaap <schaap@astron.nl> Date: Mon, 7 Oct 2019 13:35:59 +0200 Subject: [PATCH] SW-826: adding Casacore.casa as dependency on LCS/Common makes many lofar libs dependend on 3rd party libs which we don't actually use. This hinders us in deployment and maintenance on various systems. Hence, I removed the hard dependency on Casacore.casa, and made the empty-stub-CasaLogSink print out a warning message. --- LCS/Common/CMakeLists.txt | 2 +- LCS/Common/src/CasaLogSink.cc | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/LCS/Common/CMakeLists.txt b/LCS/Common/CMakeLists.txt index 8d998fa18d0..44ee1fe2c7d 100644 --- a/LCS/Common/CMakeLists.txt +++ b/LCS/Common/CMakeLists.txt @@ -3,7 +3,7 @@ lofar_package(Common 3.3) include(LofarFindPackage) -lofar_find_package(Casacore COMPONENTS casa) +# lofar_find_package(Casacore COMPONENTS casa) lofar_find_package(Boost REQUIRED) lofar_find_package(Readline) diff --git a/LCS/Common/src/CasaLogSink.cc b/LCS/Common/src/CasaLogSink.cc index d6de31d8593..8a8706bc7d4 100644 --- a/LCS/Common/src/CasaLogSink.cc +++ b/LCS/Common/src/CasaLogSink.cc @@ -108,7 +108,9 @@ namespace LOFAR { #else void CasaLogSink::attach() - {} + { + cout << "WARNING: no casa logging available." << endl; + } #endif } // end namespaces -- GitLab