From cc2edc715a12e98056f121192bb1c69a7f1f6127 Mon Sep 17 00:00:00 2001
From: rbokhorst <rbokhorst@astron.nl>
Date: Tue, 6 Nov 2018 13:11:21 +0000
Subject: [PATCH] OSB-31: fixed some inefficiencies
---
.../src/components/StationTestSummary.js | 10 +++++-----
.../maintenancedb_view/src/pages/LandingPage.js | 2 +-
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/LCU/Maintenance/MDB_WebView/maintenancedb_view/src/components/StationTestSummary.js b/LCU/Maintenance/MDB_WebView/maintenancedb_view/src/components/StationTestSummary.js
index 3a345d78a20..dcc89616474 100644
--- a/LCU/Maintenance/MDB_WebView/maintenancedb_view/src/components/StationTestSummary.js
+++ b/LCU/Maintenance/MDB_WebView/maintenancedb_view/src/components/StationTestSummary.js
@@ -49,7 +49,7 @@ class STSRow extends Component {
class ToolBar extends Component {
- onErrorsOnlyClick(selected) {
+ onErrorsOnlyClick = () => {
this.props.onChange('allErrorTypes', !this.props.allErrorTypes );
}
@@ -57,8 +57,8 @@ class ToolBar extends Component {
return (
<div className="sts-toolbar">
{ this.props.allErrorTypes
- ? <Button color="info" size="xs" onClick={() => this.onErrorsOnlyClick()} active>All types</Button>
- : <Button color="info" size="xs" onClick={() => this.onErrorsOnlyClick()}>All types</Button>
+ ? <Button color="info" size="xs" onClick={this.onErrorsOnlyClick} active>All types</Button>
+ : <Button color="info" size="xs" onClick={this.onErrorsOnlyClick}>All types</Button>
}
</div>
);
@@ -78,7 +78,7 @@ class StationTestSummaryC extends Component {
};
/* Handle changes of selected filters in the ToolBar */
- onToolbarChange(key, value) {
+ onToolbarChange = (key, value) => {
let obj = {};
obj[key] = value;
this.setState(obj);
@@ -160,7 +160,7 @@ class StationTestSummaryC extends Component {
<React.Fragment>
<h5 className="react-grid-item-header">
Station test summary
- <ToolBar onChange={(key,value) => this.onToolbarChange(key,value) } allErrorTypes={this.state.allErrorTypes} />
+ <ToolBar onChange={this.onToolbarChange} allErrorTypes={this.state.allErrorTypes} />
</h5>
<div className="react-grid-item-body">
<Table bordered hover size="sm" className="sts-table">
diff --git a/LCU/Maintenance/MDB_WebView/maintenancedb_view/src/pages/LandingPage.js b/LCU/Maintenance/MDB_WebView/maintenancedb_view/src/pages/LandingPage.js
index cf560a5bf32..e734a71cab5 100644
--- a/LCU/Maintenance/MDB_WebView/maintenancedb_view/src/pages/LandingPage.js
+++ b/LCU/Maintenance/MDB_WebView/maintenancedb_view/src/pages/LandingPage.js
@@ -160,7 +160,7 @@ class LandingPageC extends Component {
<ToolBar/>
<ResponsiveGridLayout className="layout" layouts={this.props.layout.panels} measureBeforeMount={true}
breakpoints={this.props.layout.breakpoints} cols={this.props.layout.cols}
- onResizeStop={e => this.props.setNewLayout(e)}>
+ onResizeStop={this.props.setNewLayout}>
{createGridPanel({key: "ul", renderHeader: true, title: "Station overview", body: <StationOverview url={this.getStationOverviewURL()}/>})}
{createGridPanel({key: "ur", renderHeader: true, title: "Latest observations", body: <LatestObservations url={this.getLatestObservationURL()}/>})}
{createGridPanel({key: "bl", renderHeader: false, body: <StationTestSummary url={this.getStationTestSummaryURL()}/>})}
--
GitLab