From b10cab224e2e1df2bbf9904d76a08b70d506340b Mon Sep 17 00:00:00 2001
From: Joris van Zwieten <zwieten@astron.nl>
Date: Thu, 21 Jan 2010 13:34:45 +0000
Subject: [PATCH] Bug 1453: Removed reversal of azimuth from HamakerDipole, as
it seems to be wrong: in the model, positive azimuth runs from the positive
x-dipole to the positive y-dipole. Assuming the positive y-dipole is eastward
from the positive x-dipole, azimuth runs positively "in the real world" as
well.
---
CEP/Calibration/BBSKernel/src/Expr/HamakerDipole.cc | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/CEP/Calibration/BBSKernel/src/Expr/HamakerDipole.cc b/CEP/Calibration/BBSKernel/src/Expr/HamakerDipole.cc
index 03bafa43c40..69be9803b12 100644
--- a/CEP/Calibration/BBSKernel/src/Expr/HamakerDipole.cc
+++ b/CEP/Calibration/BBSKernel/src/Expr/HamakerDipole.cc
@@ -179,10 +179,8 @@ const JonesMatrix::View HamakerDipole::evaluateImpl(const Grid &grid,
for(size_t t = 0; t < nTime; ++t)
{
- // Correct azimuth for dipole orientation and sign flip (because in the
- // definition of the beam model positive azimuth is defined as North
- // over West).
- const double phi = -(az[t] - angle);
+ // Correct azimuth for dipole orientation.
+ const double phi = az[t] - angle;
// NB: The model is parameterized in terms of zenith angle. The
// appropriate conversion is taken care of below.
--
GitLab