From aba57a7cf391c28e6de98bd483721d3a12cb692c Mon Sep 17 00:00:00 2001
From: Jorrit Schaap <schaap@astron.nl>
Date: Wed, 13 Jan 2016 15:51:00 +0000
Subject: [PATCH] Task #8888: fix: overidden methods in Service should be
private just as in super class
---
LCS/Messaging/python/messaging/Service.py | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/LCS/Messaging/python/messaging/Service.py b/LCS/Messaging/python/messaging/Service.py
index 95bc8f18be6..9812ccefff5 100644
--- a/LCS/Messaging/python/messaging/Service.py
+++ b/LCS/Messaging/python/messaging/Service.py
@@ -219,15 +219,15 @@ class Service(AbstractBusListener):
args = self._threads[currentThread]
return args['service_handler']
- def onListenLoopBegin(self):
+ def _onListenLoopBegin(self):
"Called before main processing loop is entered."
self._getServiceHandlerForCurrentThread().prepare_loop()
- def onBeforeReceiveMessage(self):
+ def _onBeforeReceiveMessage(self):
"Called in main processing loop just before a blocking wait for messages is done."
self._getServiceHandlerForCurrentThread().prepare_receive()
- def handleMessage(self, lofar_msg):
+ def _handleMessage(self, lofar_msg):
service_handler = self._getServiceHandlerForCurrentThread()
try:
@@ -296,12 +296,12 @@ class Service(AbstractBusListener):
logger.info("[Service:] BackTrace: %s", str( backtrace ))
self._send_reply(None, status, lofar_msg.reply_to, errtxt=errtxt, backtrace=backtrace)
- def onAfterReceiveMessage(self, successful):
+ def _onAfterReceiveMessage(self, successful):
"Called in the main loop after the result was send back to the requester."
"@successful@ reflects the state of the handling: true/false"
self._getServiceHandlerForCurrentThread().finalize_handling(successful)
- def onListenLoopEnd(self):
+ def _onListenLoopEnd(self):
"Called after main processing loop is finished."
self._getServiceHandlerForCurrentThread().finalize_loop()
--
GitLab