From a286302d6d5d56d35e7e5b2e14e61941324d03a0 Mon Sep 17 00:00:00 2001
From: Auke Klazema <klazema@astron.nl>
Date: Wed, 8 Mar 2017 09:59:21 +0000
Subject: [PATCH] Task #10253: Added const & to parameters

---
 MAC/WinCCServices/src/ConfigReader.h                     | 4 ++--
 MAC/WinCCServices/src/ConfigReaderImpl.cc                | 6 +++---
 MAC/WinCCServices/src/ConfigReaderImpl.h                 | 4 ++--
 MAC/WinCCServices/src/HotLinkWaitForAnswerFactory.h      | 2 +-
 MAC/WinCCServices/src/HotLinkWaitForAnswerFactoryImpl.cc | 2 +-
 MAC/WinCCServices/src/HotLinkWaitForAnswerFactoryImpl.h  | 2 +-
 MAC/WinCCServices/src/PublisherResources.h               | 2 +-
 MAC/WinCCServices/src/PublisherWaitForAnswer.cc          | 5 +++--
 MAC/WinCCServices/src/PublisherWaitForAnswer.h           | 4 ++--
 MAC/WinCCServices/src/ToBus.h                            | 2 +-
 MAC/WinCCServices/src/ToBusImpl.cc                       | 4 ++--
 MAC/WinCCServices/src/ToBusImpl.h                        | 4 ++--
 MAC/WinCCServices/src/WinCCWrapper.h                     | 2 +-
 MAC/WinCCServices/src/WinCCWrapperImpl.cc                | 6 +++---
 MAC/WinCCServices/src/WinCCWrapperImpl.h                 | 4 ++--
 MAC/WinCCServices/test/MockConfigReader.cc               | 7 +++----
 MAC/WinCCServices/test/MockConfigReader.h                | 7 +++----
 17 files changed, 33 insertions(+), 34 deletions(-)

diff --git a/MAC/WinCCServices/src/ConfigReader.h b/MAC/WinCCServices/src/ConfigReader.h
index 832adde360e..3cb3afa09f2 100644
--- a/MAC/WinCCServices/src/ConfigReader.h
+++ b/MAC/WinCCServices/src/ConfigReader.h
@@ -28,8 +28,8 @@ namespace LOFAR {
 class ConfigReader
 {
 public:
-    virtual void load(std::string config_file_name) = 0;
-    virtual std::string get_string(std::string string_name) = 0;
+    virtual void load(const std::string &config_file_name) = 0;
+    virtual std::string get_string(const std::string &string_name) = 0;
 };
 
     } // namespace WINCCSERVICES
diff --git a/MAC/WinCCServices/src/ConfigReaderImpl.cc b/MAC/WinCCServices/src/ConfigReaderImpl.cc
index 640dd744ff8..2e360dfea75 100644
--- a/MAC/WinCCServices/src/ConfigReaderImpl.cc
+++ b/MAC/WinCCServices/src/ConfigReaderImpl.cc
@@ -26,9 +26,9 @@ namespace LOFAR {
 
 using namespace std;
 
-void ConfigReaderImpl::load(std::string config_file_name)
+void ConfigReaderImpl::load(const std::string &config_file_name)
 {
-    string configPath = configLocator.locate(config_file_name);
+    const string configPath = configLocator.locate(config_file_name);
 
     if(configPath != "")
     {
@@ -40,7 +40,7 @@ void ConfigReaderImpl::load(std::string config_file_name)
     }
 }
 
-std::string ConfigReaderImpl::get_string(std::string string_name)
+std::string ConfigReaderImpl::get_string(const std::string &string_name)
 {
     return parameterSet->getString(string_name);
 
diff --git a/MAC/WinCCServices/src/ConfigReaderImpl.h b/MAC/WinCCServices/src/ConfigReaderImpl.h
index f5131236ed5..3d9a8e2d9b6 100644
--- a/MAC/WinCCServices/src/ConfigReaderImpl.h
+++ b/MAC/WinCCServices/src/ConfigReaderImpl.h
@@ -34,8 +34,8 @@ namespace LOFAR {
 class ConfigReaderImpl : public ConfigReader
 {
 public:
-    void load(std::string config_file_name);
-    std::string get_string(std::string string_name);
+    void load(const std::string &config_file_name);
+    std::string get_string(const std::string &string_name);
 private:
     ConfigLocator configLocator;
     std::unique_ptr<ParameterSet> parameterSet;
diff --git a/MAC/WinCCServices/src/HotLinkWaitForAnswerFactory.h b/MAC/WinCCServices/src/HotLinkWaitForAnswerFactory.h
index 5300cd6d757..703d87e0edd 100644
--- a/MAC/WinCCServices/src/HotLinkWaitForAnswerFactory.h
+++ b/MAC/WinCCServices/src/HotLinkWaitForAnswerFactory.h
@@ -30,7 +30,7 @@ namespace LOFAR {
 class HotLinkWaitForAnswerFactory
 {
 public:
-    virtual HotLinkWaitForAnswer* create(std::string type) = 0;
+    virtual HotLinkWaitForAnswer* create(const std::string &type) = 0;
 };
 
     } // namespace WINCCSERVICES
diff --git a/MAC/WinCCServices/src/HotLinkWaitForAnswerFactoryImpl.cc b/MAC/WinCCServices/src/HotLinkWaitForAnswerFactoryImpl.cc
index 72d59e44d05..48dae4ccc4e 100644
--- a/MAC/WinCCServices/src/HotLinkWaitForAnswerFactoryImpl.cc
+++ b/MAC/WinCCServices/src/HotLinkWaitForAnswerFactoryImpl.cc
@@ -33,7 +33,7 @@ HotLinkWaitForAnswerFactoryImpl::HotLinkWaitForAnswerFactoryImpl(ToBus &toBus, D
 {
 }
 
-HotLinkWaitForAnswer* HotLinkWaitForAnswerFactoryImpl::create(std::string type)
+HotLinkWaitForAnswer* HotLinkWaitForAnswerFactoryImpl::create(const std::string &type)
 {
     HotLinkWaitForAnswer* wait = nullptr;
 
diff --git a/MAC/WinCCServices/src/HotLinkWaitForAnswerFactoryImpl.h b/MAC/WinCCServices/src/HotLinkWaitForAnswerFactoryImpl.h
index 32b3610fc4d..24e647a745e 100644
--- a/MAC/WinCCServices/src/HotLinkWaitForAnswerFactoryImpl.h
+++ b/MAC/WinCCServices/src/HotLinkWaitForAnswerFactoryImpl.h
@@ -36,7 +36,7 @@ class HotLinkWaitForAnswerFactoryImpl : public HotLinkWaitForAnswerFactory
 {
 public:
     HotLinkWaitForAnswerFactoryImpl(ToBus &toBus, DataPointNameResolver &dataPointNameResolver);
-    HotLinkWaitForAnswer* create(std::string type);
+    HotLinkWaitForAnswer* create(const std::string &type);
 private:
     ToBus& toBus;
     DataPointNameResolver& dataPointNameResolver;
diff --git a/MAC/WinCCServices/src/PublisherResources.h b/MAC/WinCCServices/src/PublisherResources.h
index f5fd54e7c77..2c8b2c12750 100644
--- a/MAC/WinCCServices/src/PublisherResources.h
+++ b/MAC/WinCCServices/src/PublisherResources.h
@@ -32,7 +32,7 @@ namespace LOFAR {
 class PublisherResources
 {
 public:
-    PublisherResources(ConfigReader& configReader);
+    PublisherResources(ConfigReader &configReader);
     const std::vector<std::string> & getDataPoints() { return dataPoints; }
     const std::string & getQueueName() { return queueName; }
 
diff --git a/MAC/WinCCServices/src/PublisherWaitForAnswer.cc b/MAC/WinCCServices/src/PublisherWaitForAnswer.cc
index f6b56fdaa8d..25f7176e94d 100644
--- a/MAC/WinCCServices/src/PublisherWaitForAnswer.cc
+++ b/MAC/WinCCServices/src/PublisherWaitForAnswer.cc
@@ -64,14 +64,15 @@ std::string PublisherWaitForAnswer::get_datapoint_name(const DpVCItem* const ite
     return dataPointNameResolver.getName(dpIdentifier);
 }
 
-void PublisherWaitForAnswer::send_monitor_message(string name, string value)
+void PublisherWaitForAnswer::send_monitor_message(const string &name, const string &value)
 {
     Messaging::MonitoringMessage sendMsg = create_monitor_message(name, value);
 
     toBus.send(sendMsg);
 }
 
-LOFAR::Messaging::MonitoringMessage PublisherWaitForAnswer::create_monitor_message(string name, string value)
+LOFAR::Messaging::MonitoringMessage PublisherWaitForAnswer::create_monitor_message(
+    const string &name, const string &value)
 {
     Messaging::MonitoringMessage sendMsg;
     string subject = string("WinCCPublisher : ") + name;
diff --git a/MAC/WinCCServices/src/PublisherWaitForAnswer.h b/MAC/WinCCServices/src/PublisherWaitForAnswer.h
index de9af200918..30ca3a958f6 100644
--- a/MAC/WinCCServices/src/PublisherWaitForAnswer.h
+++ b/MAC/WinCCServices/src/PublisherWaitForAnswer.h
@@ -47,8 +47,8 @@ private:
 
     void handle_group_item(const DpVCItem* const item);
     std::string get_datapoint_name(const DpVCItem* const item);
-    void send_monitor_message(std::string name, std::string value);
-    Messaging::MonitoringMessage create_monitor_message(std::string name, std::string value);
+    void send_monitor_message(const std::string &name, const std::string &value);
+    Messaging::MonitoringMessage create_monitor_message(const std::string &name, const std::string &value);
 };
 
     } // namespace WINCCSERVICES
diff --git a/MAC/WinCCServices/src/ToBus.h b/MAC/WinCCServices/src/ToBus.h
index 83058c5da84..764ee0b9431 100644
--- a/MAC/WinCCServices/src/ToBus.h
+++ b/MAC/WinCCServices/src/ToBus.h
@@ -28,7 +28,7 @@ namespace LOFAR {
 class ToBus
 {
 public:
-    virtual void send(const Messaging::Message& message) = 0;
+    virtual void send(const Messaging::Message &message) = 0;
 };
 
     } // namespace WINCCSERVICES
diff --git a/MAC/WinCCServices/src/ToBusImpl.cc b/MAC/WinCCServices/src/ToBusImpl.cc
index ea0feaa32ab..545cb4f1406 100644
--- a/MAC/WinCCServices/src/ToBusImpl.cc
+++ b/MAC/WinCCServices/src/ToBusImpl.cc
@@ -24,12 +24,12 @@ namespace LOFAR {
 
 using namespace std;
 
-ToBusImpl::ToBusImpl(const string& address) :
+ToBusImpl::ToBusImpl(const string &address) :
     toBus(address)
 {
 }
 
-void ToBusImpl::send(const Messaging::Message& message)
+void ToBusImpl::send(const Messaging::Message &message)
 {
     toBus.send(message);
 }
diff --git a/MAC/WinCCServices/src/ToBusImpl.h b/MAC/WinCCServices/src/ToBusImpl.h
index 5530fde59be..d2e0cc5b479 100644
--- a/MAC/WinCCServices/src/ToBusImpl.h
+++ b/MAC/WinCCServices/src/ToBusImpl.h
@@ -33,8 +33,8 @@ namespace LOFAR {
 class ToBusImpl : public ToBus
 {
 public:
-    ToBusImpl(const std::string& address);
-    void send(const Messaging::Message& message);
+    ToBusImpl(const std::string &address);
+    void send(const Messaging::Message &message);
 private:
     Messaging::ToBus toBus;
 };
diff --git a/MAC/WinCCServices/src/WinCCWrapper.h b/MAC/WinCCServices/src/WinCCWrapper.h
index 8a4c77c4db4..eff52c744b5 100644
--- a/MAC/WinCCServices/src/WinCCWrapper.h
+++ b/MAC/WinCCServices/src/WinCCWrapper.h
@@ -32,7 +32,7 @@ class WinCCWrapper
 {
 public:
     virtual void init() = 0;
-    virtual bool connect_datapoints(std::vector<std::string> datapoints) = 0;
+    virtual bool connect_datapoints(const std::vector<std::string> &datapoints) = 0;
     virtual void run() = 0;
 };
 
diff --git a/MAC/WinCCServices/src/WinCCWrapperImpl.cc b/MAC/WinCCServices/src/WinCCWrapperImpl.cc
index 68d57bebc40..f50eba6028c 100644
--- a/MAC/WinCCServices/src/WinCCWrapperImpl.cc
+++ b/MAC/WinCCServices/src/WinCCWrapperImpl.cc
@@ -28,7 +28,7 @@ using namespace std;
 
 PVSSboolean WinCCWrapperImpl::doExit = PVSS_FALSE;
 
-WinCCWrapperImpl::WinCCWrapperImpl(HotLinkWaitForAnswerFactory& factory) :
+WinCCWrapperImpl::WinCCWrapperImpl(HotLinkWaitForAnswerFactory &factory) :
     Manager(ManagerIdentifier(API_MAN, Resources::getManNum())),
     factory(factory)
 {
@@ -63,9 +63,9 @@ void WinCCWrapperImpl::init()
     connectToEvent();
 }
 
-bool WinCCWrapperImpl::connect_datapoints(std::vector<std::string> dataPoints)
+bool WinCCWrapperImpl::connect_datapoints(const std::vector<std::string> &dataPoints)
 {
-    for(vector<string>::iterator it = dataPoints.begin(); it != dataPoints.end(); it++)
+    for(vector<string>::const_iterator it = dataPoints.begin(); it != dataPoints.end(); it++)
     {
         DpIdentList  dpList;
         DpIdentifier dpIdConnect;
diff --git a/MAC/WinCCServices/src/WinCCWrapperImpl.h b/MAC/WinCCServices/src/WinCCWrapperImpl.h
index c8a2270d7b1..f08116e2a46 100644
--- a/MAC/WinCCServices/src/WinCCWrapperImpl.h
+++ b/MAC/WinCCServices/src/WinCCWrapperImpl.h
@@ -35,9 +35,9 @@ namespace LOFAR {
 class WinCCWrapperImpl : public WinCCWrapper, public Manager
 {
 public:
-    WinCCWrapperImpl(HotLinkWaitForAnswerFactory& factory);
+    WinCCWrapperImpl(HotLinkWaitForAnswerFactory &factory);
     void init();
-    bool connect_datapoints(std::vector<std::string> dataPoints);
+    bool connect_datapoints(const std::vector<std::string> &dataPoints);
     void run();
 
     virtual void signalHandler(int sig);
diff --git a/MAC/WinCCServices/test/MockConfigReader.cc b/MAC/WinCCServices/test/MockConfigReader.cc
index e2b9840dd70..cfb7289b523 100644
--- a/MAC/WinCCServices/test/MockConfigReader.cc
+++ b/MAC/WinCCServices/test/MockConfigReader.cc
@@ -24,17 +24,16 @@ namespace LOFAR {
 
 using namespace std;
 
-void MockConfigReader::load(std::string config_file_name)
+void MockConfigReader::load(const std::string &)
 {
-    config_file_name = config_file_name;
 }
 
-std::string MockConfigReader::get_string(std::string string_name)
+std::string MockConfigReader::get_string(const std::string &string_name)
 {
     return values[string_name];
 }
 
-void MockConfigReader::set_string(std::string string_name, std::string string_value)
+void MockConfigReader::set_string(const std::string &string_name, const std::string &string_value)
 {
     values[string_name] = string_value;
 }
diff --git a/MAC/WinCCServices/test/MockConfigReader.h b/MAC/WinCCServices/test/MockConfigReader.h
index 9923190ce72..9b518de2b2c 100644
--- a/MAC/WinCCServices/test/MockConfigReader.h
+++ b/MAC/WinCCServices/test/MockConfigReader.h
@@ -30,12 +30,11 @@ namespace LOFAR {
 class MockConfigReader : public ConfigReader
 {
 public:
-    void load(std::string config_file_name);
-    std::string get_string(std::string string_name);
-    void set_string(std::string string_name, std::string string_value);
+    void load(const std::string &);
+    std::string get_string(const std::string &string_name);
+    void set_string(const std::string &string_name, const std::string &string_value);
 private:
     std::map<std::string, std::string> values;
-    std::string config_file_name;
 };
 
     } // namespace WINCCSERVICES
-- 
GitLab