From a154de80ef1d2511a2b5424e888805417c64f64c Mon Sep 17 00:00:00 2001
From: Alexander van Amesfoort <amesfoort@astron.nl>
Date: Tue, 9 May 2017 21:18:03 +0000
Subject: [PATCH] Task #9939: RA assigner: add comments to clarify warning wrt
 not finding predecessor and successor to link to in radb

---
 SAS/ResourceAssignment/ResourceAssigner/lib/assignment.py | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/SAS/ResourceAssignment/ResourceAssigner/lib/assignment.py b/SAS/ResourceAssignment/ResourceAssigner/lib/assignment.py
index df322386375..a06c969cf61 100755
--- a/SAS/ResourceAssignment/ResourceAssigner/lib/assignment.py
+++ b/SAS/ResourceAssignment/ResourceAssigner/lib/assignment.py
@@ -390,6 +390,9 @@ class ResourceAssigner():
                                 predecessor_task['mom_id'], predecessor_task['otdb_id'], task['mom_id'], task['otdb_id'])
                     self.radbrpc.insertTaskPredecessor(task['id'], predecessor_task['id'])
             else:
+                # Occurs when setting a pipeline to prescheduled while a predecessor has e.g. never been beyond approved,
+                # which is in principle valid. The link in the radb will be made later via processSuccessors() below.
+                # Alternatively, a predecessor could have been deleted.
                 logger.warning('could not find predecessor task with mom_id=%s in radb for task otdb_id=%s', predecessor_mom_id, task['otdb_id'])
 
 
@@ -414,6 +417,9 @@ class ResourceAssigner():
                     self.radbrpc.insertTaskPredecessor(successor_task['id'], task['id'])
                 movePipelineAfterItsPredecessors(successor_task, self.radbrpc)
             else:
+                # Occurs when settings a obs or task to prescheduled while a successor has e.g. not yet been beyond approved,
+                # which is quite normal. The link in the radb will be made later via processPredecessors() above.
+                # Alternatively, a successor could have been deleted.
                 logger.warning('could not find successor task with mom_id=%s in radb for task otdb_id=%s', successor_mom_id, task['otdb_id'])
 
     def getMaxPredecessorEndTime(self, specification_tree):
-- 
GitLab