Commit 60639a24 authored by Sarod Yatawatta's avatar Sarod Yatawatta

remove FIXME if not needed

parent 73c5c92f
......@@ -48,7 +48,7 @@ namespace LOFAR
QuantizeOutputKernel::Parameters::Parameters(const Parset& ps) :
Kernel::Parameters("quantizeOutput"),
nrChannels(ps.settings.beamFormer.coherentSettings.nrChannels),
nrSamplesPerChannel(ps.settings.blockSize / (nrChannels*ps.settings.beamFormer.coherentSettings.timeIntegrationFactor)), //FIXME - redues samples by integration factor
nrSamplesPerChannel(ps.settings.blockSize / (nrChannels*ps.settings.beamFormer.coherentSettings.timeIntegrationFactor)), // reduce the number of samples by the integration factor
nrTABs(ps.settings.beamFormer.maxNrCoherentTABsPerSAP()),
nrStokes(ps.settings.beamFormer.coherentSettings.nrStokes)
......@@ -73,7 +73,7 @@ namespace LOFAR
case QuantizeOutputKernel::OUTPUT_DATA:
return
(size_t) nrChannels * nrSamplesPerChannel *
nrStokes * nrTABs * sizeof(float); //FIXME
nrStokes * nrTABs * sizeof(float); //This needs to be changed to correct size
//Add extra buffer sizers here
default:
THROW(GPUProcException, "Invalid bufferType (" << bufferType << ")");
......@@ -92,7 +92,7 @@ namespace LOFAR
setArg(0, buffers.output);
setArg(1, buffers.input);
//FIXME: add extra args here
// Add extra args here
size_t nrSamples= params.nrTABs*params.nrChannels*params.nrStokes*params.nrSamplesPerChannel;
......
......@@ -78,7 +78,7 @@ namespace LOFAR
quantizeOutput(ps.settings.beamFormer.coherentSettings.quantizerSettings.enabled
? new KernelFactory<QuantizeOutputKernel>(QuantizeOutputKernel::Parameters(ps))
: NULL) //FIXME
: NULL)
{
}
......@@ -131,7 +131,7 @@ namespace LOFAR
factories.coherentStokes.create(queue,
devC, devD));
// FIXME D -> C
// if quntizer is running D -> C
if (quantizeOutputFlag) {
quantizeOutputKernel = std::unique_ptr<QuantizeOutputKernel>(
factories.quantizeOutput->create(queue,
......@@ -189,7 +189,7 @@ void BeamFormerCoherentStep::process(const SubbandProcInputData &input)
coherentStokesKernel->enqueue(input.blockID);
if (quantizeOutputFlag) {
quantizeOutputKernel->enqueue(input.blockID); //FIXME
quantizeOutputKernel->enqueue(input.blockID);
}
}
......@@ -200,7 +200,7 @@ void BeamFormerCoherentStep::readOutput(SubbandProcOutputData &output)
return;
output.coherentData.resizeOneDimensionInplace(0, nrCoherent(output.blockID));
queue.readBuffer(output.coherentData, outputBuffer(), outputCounter, false); //FIXME
queue.readBuffer(output.coherentData, outputBuffer(), outputCounter, false); //FIXME this needs to read multiple buffers if quantized
}
......
......@@ -67,7 +67,7 @@ namespace LOFAR
SmartPtr< KernelFactory<FIR_FilterKernel> > coherentFirFilter;
SmartPtr< KernelFactory<FFT_Kernel> > coherentFinalFFT;
KernelFactory<CoherentStokesKernel> coherentStokes;
SmartPtr< KernelFactory<QuantizeOutputKernel> > quantizeOutput; //FIXME: use SmartPtr
SmartPtr< KernelFactory<QuantizeOutputKernel> > quantizeOutput;
};
BeamFormerCoherentStep(const Parset &parset,
......
......@@ -75,7 +75,7 @@ namespace LOFAR
quantizeOutput(ps.settings.beamFormer.incoherentSettings.quantizerSettings.enabled
? new KernelFactory<QuantizeOutputKernel>(QuantizeOutputKernel::Parameters(ps))
: NULL) //FIXME
: NULL)
{
}
......@@ -173,7 +173,7 @@ namespace LOFAR
incoherentStokesKernel->enqueue(input.blockID);
if (quantizeOutputFlag) {
quantizeOutputKernel->enqueue(input.blockID); //FIXME
quantizeOutputKernel->enqueue(input.blockID);
}
}
......@@ -185,7 +185,7 @@ namespace LOFAR
return;
output.incoherentData.resizeOneDimensionInplace(0, nrIncoherent(output.blockID));
queue.readBuffer(output.incoherentData, outputBuffer(), outputCounter, false); //FIXME
queue.readBuffer(output.incoherentData, outputBuffer(), outputCounter, false); //FIXME : this need reading multiple buffers if quantized
}
}
}
......@@ -62,7 +62,7 @@ namespace LOFAR
SmartPtr< KernelFactory<FIR_FilterKernel> > incoherentFirFilter;
SmartPtr< KernelFactory<FFT_Kernel> > incoherentFinalFFT;
KernelFactory<IncoherentStokesKernel> incoherentStokes;
SmartPtr< KernelFactory<QuantizeOutputKernel> > quantizeOutput; //FIXME
SmartPtr< KernelFactory<QuantizeOutputKernel> > quantizeOutput;
};
BeamFormerIncoherentStep(const Parset &parset,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment