diff --git a/CEP/Pipeline/framework/lofarpipe/support/remotecommand.py b/CEP/Pipeline/framework/lofarpipe/support/remotecommand.py index 4df285da05bca4ddc0c2ca5db638c57c36e2bc93..cdef09c0b9106db4a9fe90b28d0880ace23a43a9 100644 --- a/CEP/Pipeline/framework/lofarpipe/support/remotecommand.py +++ b/CEP/Pipeline/framework/lofarpipe/support/remotecommand.py @@ -276,19 +276,24 @@ class ComputeJob(object): self.results['returncode'] = 1 error.set() return 1 - cmdarray = run_remote_command( - config, - logger, - self.host, - self.command, - { + + environment = { "PATH": os.environ.get('PATH'), "PYTHONPATH": os.environ.get('PYTHONPATH'), "LD_LIBRARY_PATH": os.environ.get('LD_LIBRARY_PATH'), "LOFARROOT" : os.environ.get('LOFARROOT'), "LOFARENV" : os.environ.get('LOFARENV',''), "QUEUE_PREFIX" : os.environ.get('QUEUE_PREFIX','') - }, + } + if "cores" in self.resources: + environment["OMP_NUM_THREADS"] = str(self.resources["cores"]) + + cmdarray = run_remote_command( + config, + logger, + self.host, + self.command, + environment, arguments = [id, jobhost, jobport], resources = self.resources ) diff --git a/CEP/Pipeline/recipes/sip/nodes/dppp.py b/CEP/Pipeline/recipes/sip/nodes/dppp.py index 6ef03658284f956278bf2bc0850586954c546c2e..7f803b6704d8e4259e5580354756fc91c59b3f6a 100644 --- a/CEP/Pipeline/recipes/sip/nodes/dppp.py +++ b/CEP/Pipeline/recipes/sip/nodes/dppp.py @@ -111,10 +111,6 @@ class dppp(LOFARnodeTCP): ) shutil.copytree(infile, tmpfile) - # Limit number of threads used. - self.environment['OMP_NUM_THREADS'] = str(nthreads) - self.logger.debug("Using %s threads for NDPPP" % nthreads) - # ***************************************************************** # 3. Update the parset with locally calculate information diff --git a/CEP/Pipeline/recipes/sip/nodes/imager_prepare.py b/CEP/Pipeline/recipes/sip/nodes/imager_prepare.py index b590cc806804ce0c8ed8fcfcb2faf426f413ccad..7ff314cd11047ec42c46e1c2c77c1046b704adb8 100644 --- a/CEP/Pipeline/recipes/sip/nodes/imager_prepare.py +++ b/CEP/Pipeline/recipes/sip/nodes/imager_prepare.py @@ -220,9 +220,6 @@ class imager_prepare(LOFARnodeTCP): Muckable function running the dppp executable. Wraps dppp with catchLog4CPLus and catch_segfaults """ - # TODO: cpu limited is static at this location - environment['OMP_NUM_THREADS'] = str(8) - self.logger.debug("Using %s threads for ndppp" % 8) with CatchLog4CPlus(working_dir, self.logger.name + "." + os.path.basename("imager_prepare_ndppp"), os.path.basename(ndppp)) as logger: diff --git a/CEP/Pipeline/recipes/sip/nodes/selfcal_awimager.py b/CEP/Pipeline/recipes/sip/nodes/selfcal_awimager.py index db7267f7c3f03daac89d6ca2fe0ea83969834741..3343b52f0f3b98efc4e850949b6bd5078b1b806d 100644 --- a/CEP/Pipeline/recipes/sip/nodes/selfcal_awimager.py +++ b/CEP/Pipeline/recipes/sip/nodes/selfcal_awimager.py @@ -174,11 +174,6 @@ class selfcal_awimager(LOFARnodeTCP): # ***************************************************************** # 5. Run the awimager with the parameterset - # TODO: FIXME: manually Limit number of threads used. - omp_num_threads = 8 - self.environment['OMP_NUM_THREADS'] = str(omp_num_threads) - self.logger.debug("Using %s threads for swimager" % omp_num_threads) - cmd = [executable, calculated_parset_path] self.logger.debug("Parset used for awimager run:") self.logger.debug(cmd)