From 1b1b27f69f4a3df9013bd8edec543f7a5e8cfeb1 Mon Sep 17 00:00:00 2001 From: Jorrit Schaap <schaap@astron.nl> Date: Mon, 11 Apr 2016 11:45:15 +0000 Subject: [PATCH] Task #8887: use for..in loops --- .../lib/static/app/controllers/datacontroller.js | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/SAS/ResourceAssignment/ResourceAssignmentEditor/lib/static/app/controllers/datacontroller.js b/SAS/ResourceAssignment/ResourceAssignmentEditor/lib/static/app/controllers/datacontroller.js index d30859a5513..d5b7f4e0498 100644 --- a/SAS/ResourceAssignment/ResourceAssignmentEditor/lib/static/app/controllers/datacontroller.js +++ b/SAS/ResourceAssignment/ResourceAssignmentEditor/lib/static/app/controllers/datacontroller.js @@ -49,7 +49,7 @@ angular.module('raeApp').factory("dataService", ['$http', '$q', function($http, $http.get('/rest/tasks').success(function(result) { //convert datetime strings to Date objects - for(var i = result.tasks.length-1; i >=0; i--) { + for(var i in result.tasks) { var task = result.tasks[i]; task.starttime = new Date(task.starttime); task.endtime = new Date(task.endtime); @@ -91,7 +91,7 @@ angular.module('raeApp').factory("dataService", ['$http', '$q', function($http, var defer = $q.defer(); $http.get('/rest/resourceusages').success(function(result) { //convert datetime strings to Date objects - for(var i = result.resourceusages.length-1; i >=0; i--) { + for(var i in result.resourceusages) { var resource_usages = result.resourceusages[i].usages; for(var status in resource_usages) { @@ -113,7 +113,7 @@ angular.module('raeApp').factory("dataService", ['$http', '$q', function($http, var defer = $q.defer(); $http.get('/rest/resourceclaims').success(function(result) { //convert datetime strings to Date objects - for(var i = result.resourceclaims.length-1; i >=0; i--) { + for(var i in result.resourceclaims) { var resourceclaim = result.resourceclaims[i]; resourceclaim.starttime = new Date(resourceclaim.starttime); resourceclaim.endtime = new Date(resourceclaim.endtime); @@ -187,7 +187,7 @@ angular.module('raeApp').factory("dataService", ['$http', '$q', function($http, //convert datetime strings to Date objects var dict = {}; var list = []; - for(var i = result.momprojects.length-1; i >=0; i--) { + for(var i in result.momprojects) { var momproject = result.momprojects[i]; momproject.statustime = new Date(momproject.statustime); dict[momproject.mom_id] = momproject; @@ -279,7 +279,7 @@ angular.module('raeApp').factory("dataService", ['$http', '$q', function($http, }; var anyResourceClaims = false; - for(var i = result.changes.length-1; i >=0; i--) { + for(var i in result.changes) { try { var change = result.changes[i]; -- GitLab