diff --git a/LCU/Maintenance/MDB_tools/test/t_station_tests_watchdog.py b/LCU/Maintenance/MDB_tools/test/t_station_tests_watchdog.py index 5a98f5ff84e82f14c7b5a6bb7ca4238a3f12020e..387be781937182a558a50c3a01003ed66aadc465 100644 --- a/LCU/Maintenance/MDB_tools/test/t_station_tests_watchdog.py +++ b/LCU/Maintenance/MDB_tools/test/t_station_tests_watchdog.py @@ -15,10 +15,9 @@ class TestStationTestsWatchdog(unittest.TestCase): @patch('lofar.maintenance.utils.cli.station_tests_watchdog.mdb_client') def test_on_created_event_read_test_file(self, mock_mdb_client): - event = ('UNUSED', 'IN_CLOSE_WRITE', self.mock_path, self.mock_filename) - handle_inotify_event_create_file(event, self.mock_filename, self.mock_address ) + handle_inotify_event_create_file(event, self.mock_filename, self.mock_address) mock_mdb_client.read_stationtest_rtsm_output_to_dict.assert_called_with(self.mock_path + '/' + @@ -26,15 +25,15 @@ class TestStationTestsWatchdog(unittest.TestCase): @patch('lofar.maintenance.utils.cli.station_tests_watchdog.mdb_client') def test_on_created_event_send_test_file_content(self, mock_mdb_client): - event = ('UNUSED', 'IN_CLOSE_WRITE', self.mock_path, self.mock_filename) mock_mdb_client.read_stationtest_rtsm_output_to_dict.return_value = self.mock_content handle_inotify_event_create_file(event, self.mock_filename, self.mock_address) - mock_mdb_client.send_stationtest_rtsm_content_to_address.assert_called_with(self.mock_address, - self.mock_content) + mock_mdb_client.send_stationtest_rtsm_content_to_address.assert_called_with( + self.mock_address, + self.mock_content) @patch('lofar.maintenance.utils.cli.station_tests_watchdog.mdb_client') def test_on_created_event_wrong_expected_name_not_send_test_file_content(self, mock_mdb_client): @@ -85,20 +84,20 @@ class TestStationTestsWatchdog(unittest.TestCase): mock_mdb_client.send_stationtest_rtsm_content_to_address.assert_not_called() - @patch('lofar.maintenance.utils.cli.station_tests_watchdog.' - 'handle_inotify_event_create_file') + 'handle_inotify_event_create_file') def test_main_wait_event_loop_unexpected_exception_keyboard_interrupt(self, - handle_inotify_event_create_file_mock): + handle_inotify_event_create_file_mock): active_watch_time = 3 test_event = ('_', 'fake_type', 'fake_path', 'fake_file') observer_mock = MagicMock() observer_mock.event_gen.return_value = [test_event] handle_inotify_event_create_file_mock.side_effect = [[], Exception(), KeyboardInterrupt()] - self.assertTrue(main_wait_event_loop(observer_mock, 'fake_name', self.mock_address, active_watch_time)) - handle_inotify_event_create_file_mock.assert_has_calls([call(test_event, 'fake_name', self.mock_address)] * 3) - + self.assertTrue( + main_wait_event_loop(observer_mock, 'fake_name', self.mock_address, active_watch_time)) + handle_inotify_event_create_file_mock.assert_has_calls( + [call(test_event, 'fake_name', self.mock_address)] * 3) @patch('inotify.adapters.Inotify') def test_instantiate_file_creation_event_observer(self, inotify_mock): @@ -110,7 +109,6 @@ class TestStationTestsWatchdog(unittest.TestCase): instantiate_file_creation_event_observer(mock_path) inotify_object_partial_mock.add_watch.assert_called_with(mock_path) - @patch('lofar.maintenance.utils.cli.station_tests_watchdog.' 'setup_command_argument_parser') def test_get_settings_from_command_arguments(self, mock_setup_argument_parser): @@ -123,7 +121,6 @@ class TestStationTestsWatchdog(unittest.TestCase): mock_setup_argument_parser.assert_called() argument_parser.parse_args.assert_called() - @patch('lofar.maintenance.utils.cli.station_tests_watchdog.' 'setup_logging_framework') def test_apply_global_settings_set_verbose_logging(self, mock_setup_logging_framework): @@ -134,7 +131,6 @@ class TestStationTestsWatchdog(unittest.TestCase): mock_setup_logging_framework.assert_called_with(logging.DEBUG) - @patch('lofar.maintenance.utils.cli.station_tests_watchdog.' 'setup_logging_framework') def test_apply_global_settings_do_not_set_verbose_logging(self, mock_setup_logging_framework): @@ -145,7 +141,6 @@ class TestStationTestsWatchdog(unittest.TestCase): mock_setup_logging_framework.assert_not_called() - @patch('lofar.maintenance.utils.cli.station_tests_watchdog.' 'main_wait_event_loop') @patch('lofar.maintenance.utils.cli.station_tests_watchdog.' @@ -153,7 +148,6 @@ class TestStationTestsWatchdog(unittest.TestCase): def test_station_tests_watchdog(self, mock_instantiate_file_creation_event_observer, mock_main_wait_event_loop): - mock_arguments = [self.mock_path, self.mock_filename, '--addr', self.mock_address] mock_observer = MagicMock() @@ -165,7 +159,6 @@ class TestStationTestsWatchdog(unittest.TestCase): mock_main_wait_event_loop.assert_called_with(mock_observer, self.mock_filename, self.mock_address, MAIN_LOOP_WAIT_TIME) - @patch('lofar.maintenance.utils.cli.station_tests_watchdog.' 'main_wait_event_loop') @patch('lofar.maintenance.utils.cli.station_tests_watchdog.' @@ -184,7 +177,6 @@ class TestStationTestsWatchdog(unittest.TestCase): mock_main_wait_event_loop.assert_called_with(mock_observer, self.mock_filename, self.mock_address, MAIN_LOOP_WAIT_TIME) - @patch('lofar.maintenance.utils.cli.station_tests_watchdog.' 'sys') @patch('lofar.maintenance.utils.cli.station_tests_watchdog.' @@ -198,7 +190,6 @@ class TestStationTestsWatchdog(unittest.TestCase): mock_main_wait_event_loop, mock_logging, partial_mock_sys): - mock_arguments = [self.mock_path, self.mock_filename, '--addr', self.mock_address] partial_mock_sys.argv = mock_arguments mock_observer = MagicMock()