GitLab

Use a reference instead of a copy.

The base test no longer stores its data directly in the test_data
directory. That caused race-conditions between the two download jobs.
Thus the base tests has some minor refactoring.

RAP-309 Added the read operation, this adds the write operation.

This helper function creates a new mask from a subset of the rows. When
using -combine-frequencies all channels are stored in a single mask.
This function aids to get the channels for a specific measurement set.

An odd sized window centers on the value that's being adjusted. Due to
the bug solved the previously used window size was already 511.

Benchmarking RAP-309 and RAP-310 using vtune showed the incrementing of
red-black tree's iterator as a hotspot. It turned out the be
MedianWindow's std::set was the culprit. Switching to a sorted
std::vector improves the performance.

While adding tests for MedianWindow it turns out there were some
suspicious values. Testing with Octave's movmedian confirmed the
suspicions. The code has been adjusted to match Octave's behaviour for
finite values.

AOFlagger's code filters ±inf and nan from the Window. Octave's code
- propagates the NaN to affect all output elements,
- uses the infinite values and sorts them.

The averaging has an issue where two large values can result in an
infinite instead of the proper average. Since there are no bug reports
of customers this issue is ignored.