Can't we push these urls from gitlab environment settings ? You can set it there very nicely per environment. Safes us one day from accidently pushing logs to the central service. But for now offcourse, this works.
Yes and no, accidentally pushing to prod is not going to happen, there is already a conditional around this (notice [[ if ne.station "dev" ]]. And both your local setup and the integration tests will never be able to reach the central Consul network so lofar-central.service.consul will not resolve.
Cleaning up all these variables is nice however, but doing that for this one magic string doesn't make a lot of sense as to do it proper you need to change all these magic strings into variables. Which is well beyond the scope of this ticket.
Can't we push these urls from gitlab environment settings ? You can set it there very nicely per environment. Safes us one day from accidently pushing logs to the central service. But for now offcourse, this works.
Yes and no, accidentally pushing to prod is not going to happen, there is already a conditional around this (notice
[[ if ne.station "dev" ]]
. And both your local setup and the integration tests will never be able to reach the central Consul network solofar-central.service.consul
will not resolve.Cleaning up all these variables is nice however, but doing that for this one magic string doesn't make a lot of sense as to do it proper you need to change all these magic strings into variables. Which is well beyond the scope of this ticket.