From bc2aca25b51cb94fa1fb115c2d0aed695b90d76c Mon Sep 17 00:00:00 2001
From: thijs snijder <snijder@astron.nl>
Date: Fri, 7 May 2021 15:03:16 +0200
Subject: [PATCH] further review processing
---
devices/clients/ini_client.py | 4 ++--
devices/ini_device.py | 6 ------
2 files changed, 2 insertions(+), 8 deletions(-)
diff --git a/devices/clients/ini_client.py b/devices/clients/ini_client.py
index c099dbc8d..18500fdec 100644
--- a/devices/clients/ini_client.py
+++ b/devices/clients/ini_client.py
@@ -162,9 +162,9 @@ def data_handler(string, dtype):
# Handle special case for Bools
for i in string.split(","):
i = i.strip(" ")
- if "True" in i:
+ if "True" == i:
value.append(True)
- elif "False" in i:
+ elif "False" == i:
value.append(False)
else:
raise ValueError("String to bool failed. String is not True/False, but is: '{}'".format(i))
diff --git a/devices/ini_device.py b/devices/ini_device.py
index bc9d4b7a5..19e6b3892 100644
--- a/devices/ini_device.py
+++ b/devices/ini_device.py
@@ -96,12 +96,6 @@ class ini_device(hardware_device):
str_image_RW = attribute_wrapper(comms_annotation={"section": "image", "name": "str_image_RW"}, datatype=numpy.str_, dims=(3, 2), access=AttrWriteType.READ_WRITE)
str_image_R = attribute_wrapper(comms_annotation={"section": "image", "name": "str_image_R"}, datatype=numpy.str_, dims=(3, 2))
- @classmethod
- def attr_list(cls):
- """ Return a list of all the attribute_wrapper members of this class. """
- return [v for k, v in cls.__dict__.items() if type(v) == attribute_wrapper]
-
-
def always_executed_hook(self):
"""Method always executed before any TANGO command is executed."""
pass
--
GitLab