From a2aa10d8aa57d8fe336bb4574260a634617d92b5 Mon Sep 17 00:00:00 2001
From: snijder <snijder@astron.nl>
Date: Thu, 2 Mar 2023 14:03:42 +0100
Subject: [PATCH] L2SS-1103 added minimum and maximum values for RCU_DTH_PWR

---
 .../tangostationcontrol/devices/antennafield.py               | 4 ++++
 tangostationcontrol/tangostationcontrol/devices/recv.py       | 4 ++++
 2 files changed, 8 insertions(+)

diff --git a/tangostationcontrol/tangostationcontrol/devices/antennafield.py b/tangostationcontrol/tangostationcontrol/devices/antennafield.py
index 1f117c308..97e5e6089 100644
--- a/tangostationcontrol/tangostationcontrol/devices/antennafield.py
+++ b/tangostationcontrol/tangostationcontrol/devices/antennafield.py
@@ -593,6 +593,8 @@ class AntennaField(LOFARDevice):
         dtype=(numpy.float64,),
         max_dim_x=MAX_ANTENNA,
         doc="RCU Dither source power (dBm). Range -25 to -4.",
+        min_value=-25,
+        max_value=-4,
     )
     RCU_DTH_PWR_RW = MappedAttribute(
         "RCU_DTH_PWR_RW",
@@ -600,6 +602,8 @@ class AntennaField(LOFARDevice):
         max_dim_x=MAX_ANTENNA,
         access=AttrWriteType.READ_WRITE,
         doc="RCU Dither source power (dBm). Range -25 to -4.",
+        min_value=-25,
+        max_value=-4,
     )
     RCU_DAB_filter_on_R = MappedAttribute(
         "RCU_DAB_filter_on_R",
diff --git a/tangostationcontrol/tangostationcontrol/devices/recv.py b/tangostationcontrol/tangostationcontrol/devices/recv.py
index 26664f993..afbd47217 100644
--- a/tangostationcontrol/tangostationcontrol/devices/recv.py
+++ b/tangostationcontrol/tangostationcontrol/devices/recv.py
@@ -256,6 +256,8 @@ class RECV(OPCUADevice):
         datatype=numpy.float64,
         dims=(N_rcu, N_rcu_inp),
         doc="RCU Dither source power (dBm). Range -25 to -4.",
+        min_value=-25,
+        max_value=-4,
     )
     RCU_DTH_PWR_RW = AttributeWrapper(
         comms_annotation=["RCU_DTH_PWR_RW"],
@@ -263,6 +265,8 @@ class RECV(OPCUADevice):
         access=AttrWriteType.READ_WRITE,
         dims=(N_rcu, N_rcu_inp),
         doc="RCU Dither source power (dBm). Range -25 to -4.",
+        min_value=-25,
+        max_value=-4,
     )
     RCU_LED_green_on_R = AttributeWrapper(
         comms_annotation=["RCU_LED_green_on_R"], datatype=bool, dims=(N_rcu,)
-- 
GitLab