From 8332e6b28acdbbe20c1744abe2ac5cd63eace3a6 Mon Sep 17 00:00:00 2001
From: Jan David Mol <mol@astron.nl>
Date: Wed, 6 Apr 2022 16:19:32 +0200
Subject: [PATCH] L2SS-685: Fix FPGA_error_R formula
---
tangostationcontrol/tangostationcontrol/devices/sdp/sdp.py | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/tangostationcontrol/tangostationcontrol/devices/sdp/sdp.py b/tangostationcontrol/tangostationcontrol/devices/sdp/sdp.py
index f356c0dfc..d551c0104 100644
--- a/tangostationcontrol/tangostationcontrol/devices/sdp/sdp.py
+++ b/tangostationcontrol/tangostationcontrol/devices/sdp/sdp.py
@@ -180,8 +180,9 @@ class SDP(opcua_device):
def read_FPGA_error_R(self):
return self.read_attribute("TR_fpga_mask_R") & (
self.read_attribute("TR_fpga_communication_error_R")
- | (self.read_attribute("FPGA_firmware_version_R") != "")
- | (self.read_attribute("FPGA_jesd204b_csr_dev_syncn_R") == 0).any(axis=1)
+ | (self.read_attribute("FPGA_firmware_version_R") == "")
+ # we cannot assume all inputs of an FPGA are working until we have a mask for it
+ #| (self.read_attribute("FPGA_jesd204b_csr_dev_syncn_R") == 0).any(axis=1)
)
def read_FPGA_processing_error_R(self):
--
GitLab