From 75f1b128d1505468031ef8b0c94a337c05ebaafa Mon Sep 17 00:00:00 2001 From: Jan David Mol <mol@astron.nl> Date: Thu, 28 Oct 2021 08:33:29 +0200 Subject: [PATCH] L2SS-466: Introduce separate LOG_HOSTNAME to send logs to, representing the HOSTNAME as resolvable from the host (instead of the containers or the clients) --- docker-compose/Makefile | 8 +++++++- docker-compose/archiver.yml | 8 ++++---- docker-compose/grafana.yml | 2 +- docker-compose/prometheus.yml | 2 +- docker-compose/rest.yml | 2 +- docker-compose/tango.yml | 4 ++-- 6 files changed, 16 insertions(+), 10 deletions(-) diff --git a/docker-compose/Makefile b/docker-compose/Makefile index 649e63518..5ff69d0ee 100644 --- a/docker-compose/Makefile +++ b/docker-compose/Makefile @@ -13,7 +13,8 @@ ATTACH_COMPOSE_FILE_ARGS := $(foreach yml,$(filter-out tango.yml,$(COMPOSE_FILES # But we allow to overwrite it. NETWORK_MODE ?= tangonet -# Host name through which others can reach our control interfaces +# Host name through which others can reach our control interfaces. +# Needs to be resolvable from the containers and clients. ifneq (,$(wildcard /run/WSL)) # Microsoft Windows Subsystem for Linux HOSTNAME ?= host.docker.internal @@ -21,6 +22,10 @@ else HOSTNAME ?= $(shell hostname -f) endif +# Host name to which to send our container logs. Needs to be resolvable from +# the host. +LOG_HOSTNAME ?= localhost + # If the first make argument is "start" or "stop"... ifeq (start,$(firstword $(MAKECMDGOALS))) SERVICE_TARGET = true @@ -113,6 +118,7 @@ DOCKER_COMPOSE_ARGS := DISPLAY=$(DISPLAY) \ TANGO_HOST=$(TANGO_HOST) \ MYSQL_HOST=$(MYSQL_HOST) \ HOSTNAME=$(HOSTNAME) \ + LOG_HOSTNAME=$(LOG_HOSTNAME) \ NETWORK_MODE=$(NETWORK_MODE) \ XAUTHORITY_MOUNT=$(XAUTHORITY_MOUNT) \ CONTAINER_NAME_PREFIX=$(CONTAINER_NAME_PREFIX) \ diff --git a/docker-compose/archiver.yml b/docker-compose/archiver.yml index da37892ea..1a56516c7 100644 --- a/docker-compose/archiver.yml +++ b/docker-compose/archiver.yml @@ -20,7 +20,7 @@ services: logging: driver: syslog options: - syslog-address: udp://${HOSTNAME}:1514 + syslog-address: udp://${LOG_HOSTNAME}:1514 syslog-format: rfc3164 tag: "{{.Name}}" restart: unless-stopped @@ -45,7 +45,7 @@ services: logging: driver: syslog options: - syslog-address: udp://${HOSTNAME}:1514 + syslog-address: udp://${LOG_HOSTNAME}:1514 syslog-format: rfc3164 tag: "{{.Name}}" restart: unless-stopped @@ -70,7 +70,7 @@ services: logging: driver: syslog options: - syslog-address: udp://${HOSTNAME}:1514 + syslog-address: udp://${LOG_HOSTNAME}:1514 syslog-format: rfc3164 tag: "{{.Name}}" @@ -94,7 +94,7 @@ services: logging: driver: syslog options: - syslog-address: udp://${HOSTNAME}:1514 + syslog-address: udp://${LOG_HOSTNAME}:1514 syslog-format: rfc3164 tag: "{{.Name}}" restart: unless-stopped diff --git a/docker-compose/grafana.yml b/docker-compose/grafana.yml index eaddea1e2..29c93c52c 100644 --- a/docker-compose/grafana.yml +++ b/docker-compose/grafana.yml @@ -26,7 +26,7 @@ services: logging: driver: syslog options: - syslog-address: udp://${HOSTNAME}:1514 + syslog-address: udp://${LOG_HOSTNAME}:1514 syslog-format: rfc3164 tag: "{{.Name}}" restart: unless-stopped diff --git a/docker-compose/prometheus.yml b/docker-compose/prometheus.yml index abec3c84e..604f4bf4b 100644 --- a/docker-compose/prometheus.yml +++ b/docker-compose/prometheus.yml @@ -19,7 +19,7 @@ services: logging: driver: syslog options: - syslog-address: udp://${HOSTNAME}:1514 + syslog-address: udp://${LOG_HOSTNAME}:1514 syslog-format: rfc3164 tag: "{{.Name}}" restart: unless-stopped diff --git a/docker-compose/rest.yml b/docker-compose/rest.yml index 8e61958ba..467319399 100644 --- a/docker-compose/rest.yml +++ b/docker-compose/rest.yml @@ -36,7 +36,7 @@ services: logging: driver: syslog options: - syslog-address: udp://${HOSTNAME}:1514 + syslog-address: udp://${LOG_HOSTNAME}:1514 syslog-format: rfc3164 tag: "{{.Name}}" restart: unless-stopped diff --git a/docker-compose/tango.yml b/docker-compose/tango.yml index 420f2d005..937cc5c8e 100644 --- a/docker-compose/tango.yml +++ b/docker-compose/tango.yml @@ -31,7 +31,7 @@ services: logging: driver: syslog options: - syslog-address: udp://${HOSTNAME}:1514 + syslog-address: udp://${LOG_HOSTNAME}:1514 syslog-format: rfc3164 tag: "{{.Name}}" restart: unless-stopped @@ -64,7 +64,7 @@ services: logging: driver: syslog options: - syslog-address: udp://${HOSTNAME}:1514 + syslog-address: udp://${LOG_HOSTNAME}:1514 syslog-format: rfc3164 tag: "{{.Name}}" restart: unless-stopped -- GitLab