From 2085496f94802a1bb99226b071d30a605e0b90e9 Mon Sep 17 00:00:00 2001
From: Jan David Mol <mol@astron.nl>
Date: Fri, 6 Aug 2021 11:53:36 +0200
Subject: [PATCH] L2SS-271: Raise an error if the comms_id is not recognised.

---
 devices/devices/sdp/statistics.py | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/devices/devices/sdp/statistics.py b/devices/devices/sdp/statistics.py
index 956dbc9b5..2a9ddb9ec 100644
--- a/devices/devices/sdp/statistics.py
+++ b/devices/devices/sdp/statistics.py
@@ -129,8 +129,10 @@ class Statistics(hardware_device, metaclass=ABCMeta):
             try:
                 if i.comms_id == StatisticsClient:
                     i.set_comm_client(self.statistics_client)
-                if i.comms_id == OPCUAConnection:
+                elif i.comms_id == OPCUAConnection:
                     i.set_comm_client(self.OPCUA_client)
+                else:
+                    raise ValueError("Cannot set comm client for attribute {}: Unknown comms_id {}".format(i, i.comms_id))
             except Exception as e:
                 # use the pass function instead of setting read/write fails
                 i.set_pass_func()
-- 
GitLab