From c3aac0e84ec74dac94cdb51ce4a3e9dd15c5edf0 Mon Sep 17 00:00:00 2001
From: Katleho Madisa <katleho.madisa47@gmail.com>
Date: Mon, 21 Sep 2020 13:45:43 +0000
Subject: [PATCH] SAR-149 Ensure message logged only when new transaction ID is
generated.
---
src/ska/logging/transactions.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/ska/logging/transactions.py b/src/ska/logging/transactions.py
index 43e9572..acf865f 100644
--- a/src/ska/logging/transactions.py
+++ b/src/ska/logging/transactions.py
@@ -76,7 +76,6 @@ class Transaction:
if not self._transaction_id:
self._transaction_id = self._get_from_params_or_generate_new_id()
- self.logger.info(f"Generated transaction ID {self._transaction_id}")
if transaction_id and params.get(self._transaction_id_key):
self.logger.info(
@@ -113,6 +112,7 @@ class Transaction:
transaction_id = self._params.get(self._transaction_id_key)
if not self._is_valid_id(transaction_id):
transaction_id = self._generate_new_id()
+ self.logger.info(f"Generated transaction ID {transaction_id}")
return transaction_id
def _is_valid_id(self, transaction_id):
--
GitLab