From ae02b138c74f1ca41323f0a6bbbfa683893ace74 Mon Sep 17 00:00:00 2001
From: Anton Joubert <ajoubert@ska.ac.za>
Date: Sat, 21 Dec 2019 17:04:57 +0200
Subject: [PATCH] Move metadata validation to CI build step
katversion needs git, so the validation also needs git. Move the
metadata validation to the build step, rather than installing git
again in the publish step. The dist files from the build step are
the ones that get published, so OK to move the check there.
---
.gitlab-ci.yml | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index f29b5e5..b11934c 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -33,6 +33,7 @@ build wheel:
# TODO: consider moving git installation to ska-python-buildenv Dockerfile
- apt-get -y update
- apt-get install -y git --no-install-recommends
+ - scripts/validate-metadata.sh
- python setup.py sdist bdist_wheel
artifacts:
paths:
@@ -88,8 +89,6 @@ publish to nexus:
TWINE_USERNAME: $TWINE_USERNAME
TWINE_PASSWORD: $TWINE_PASSWORD
script:
- # Check metadata requirements
- - scripts/validate-metadata.sh
- pip install twine
- twine upload --repository-url $PYPI_REPOSITORY_URL dist/*
only:
--
GitLab