diff --git a/lofar_station_client/file_access/_compat_utils.py b/lofar_station_client/file_access/_compat_utils.py index 00f3c5922dae228821f5c7a00d904d59cb8de74e..1dc749f36a3a4769e95429b387acd4c9eec7ec1a 100644 --- a/lofar_station_client/file_access/_compat_utils.py +++ b/lofar_station_client/file_access/_compat_utils.py @@ -37,7 +37,6 @@ except ImportError: try: from inspect import get_annotations except ImportError: - import sys import types import functools diff --git a/lofar_station_client/observation/multi_station_observation.py b/lofar_station_client/observation/multi_station_observation.py index c6958c8eaa100b49f43253dab951b6804fe95dfe..df1d5f8f9b6444448b16ea7087bb668e09c4c85d 100644 --- a/lofar_station_client/observation/multi_station_observation.py +++ b/lofar_station_client/observation/multi_station_observation.py @@ -26,7 +26,6 @@ class MultiStationObservation: TIMEOUT = 10 def __init__(self, specification: dict, hosts: list): - # convert specification dict to json self._specification = specification diff --git a/lofar_station_client/observation/station_observation.py b/lofar_station_client/observation/station_observation.py index e91b1d47289b8cdfb252af160d3f4fde0263a0f0..30678f962c20c4d610d0a79edd888b8ebaa0a310 100644 --- a/lofar_station_client/observation/station_observation.py +++ b/lofar_station_client/observation/station_observation.py @@ -32,7 +32,7 @@ class StationObservation: self.station = StationFutures(specification, host) if not self.station.connected: - raise Exception(f"Was not able to connect with {host}") + raise RuntimeError(f"Was not able to connect with {host}") def start(self): """ diff --git a/lofar_station_client/statistics/collector.py b/lofar_station_client/statistics/collector.py index 4e1eae76e85a9e7144faaf250be4de785d0b3f66..985dd76caae08084f6c3c1399d70037da8341c37 100644 --- a/lofar_station_client/statistics/collector.py +++ b/lofar_station_client/statistics/collector.py @@ -505,7 +505,6 @@ class StationSSTCollector(DeviceCollectorInterface, SSTCollector): self.parse_device_attributes() def parse_device_attributes(self): - # If Tango connection has been disabled, set explicitly to None, # because otherwise default_values are inserted if not self.device or self.device.state() != DevState.ON: diff --git a/lofar_station_client/statistics/reader.py b/lofar_station_client/statistics/reader.py index d14ec47de00cb3ee70a79e96ba8646a740f07afa..2ecc10e5649b21413aaedb06dd84bee7ef479e4f 100644 --- a/lofar_station_client/statistics/reader.py +++ b/lofar_station_client/statistics/reader.py @@ -64,7 +64,6 @@ class StatisticsParser: """ def __init__(self): - # list of all statistics self.statistics = [] diff --git a/lofar_station_client/statistics/writer/hdf5.py b/lofar_station_client/statistics/writer/hdf5.py index 07201750943097baedf7b4d965224fa6492256a2..cb5eb3fe960820ab534f63024e5a58db51c4b5f1 100644 --- a/lofar_station_client/statistics/writer/hdf5.py +++ b/lofar_station_client/statistics/writer/hdf5.py @@ -133,7 +133,6 @@ class HDF5Writer(ABC): sdp_device: DeviceProxy = None, tilebeam_device: DeviceProxy = None, ): - # all variables that deal with the matrix that's currently being decoded self.file: StatisticsDataFile = None self.file_writer: HdfFileWriter[StatisticsDataFile] = None diff --git a/tests/observation/test_multi_station_observation.py b/tests/observation/test_multi_station_observation.py index e58c9ff83a8635f2479e6d39d5ec625d5133d174..b01cbf14d4d13830b7424030695307caab35a4d7 100644 --- a/tests/observation/test_multi_station_observation.py +++ b/tests/observation/test_multi_station_observation.py @@ -58,7 +58,6 @@ class TestMultiStationObservation(base.TestCase): autospec=True, ) def setUp(self, M_station): - self.station_mocks = [mock.Mock(), mock.Mock(), mock.Mock()] future = concurrent.futures.Future() diff --git a/tests/requests/test_prometheus.py b/tests/requests/test_prometheus.py index e38d8068b1af6ee3f1a6e61de2c4ced82036831c..d1b17de735efefa01e94af2b89bc02339e7357ac 100644 --- a/tests/requests/test_prometheus.py +++ b/tests/requests/test_prometheus.py @@ -27,7 +27,6 @@ from tests import base class PrometheusTest(base.TestCase): - # Multiple results for identical (x, y, attribute, station) combinations DUMMY_RESULT_DATA_DUPLICATE = """ { @@ -419,7 +418,6 @@ class PrometheusTest(base.TestCase): ) def test_attribute_history_http_error(self): - test_response = mock.Mock(status_code=404, text="") self.m_requests.get.return_value = test_response @@ -427,7 +425,6 @@ class PrometheusTest(base.TestCase): PrometheusRequests.get_attribute_history("dummy", "dummy") def test_attribute_history_prometheus_error(self): - test_response = mock.Mock( status_code=200, text=PrometheusTest.DUMMY_RESULT_INVALID_REQUEST ) diff --git a/tests/test_devices.py b/tests/test_devices.py index 10e0a33b5d44754d878477464bb781c9ac5ffc07..de3adaffc45065bb90d4436d8f0a6b797ba455d6 100644 --- a/tests/test_devices.py +++ b/tests/test_devices.py @@ -197,7 +197,6 @@ class LazyLofarDeviceProxyTest(base.TestCase): class RecvDeviceTest(MyDevice): - RCU_attenuator_dB_R = attribute( dtype=((numpy.int64,),), max_dim_x=3, @@ -236,7 +235,6 @@ class RecvDeviceTest(MyDevice): class RecvDeviceProxyTest(base.TestCase): - TEST_DEVICE_INFO = [ { "class": RecvDeviceTest,