From 09af824da1f33d6b57548dd820de1e966c1ace58 Mon Sep 17 00:00:00 2001 From: Jan David Mol <mol@astron.nl> Date: Wed, 9 Aug 2023 11:12:02 +0200 Subject: [PATCH] Fix obtaining Frequency_Band from AntennaField --- README.md | 1 + VERSION | 2 +- lofar_station_client/statistics/writer/hdf5.py | 2 +- tests/test_devices.py | 1 - 4 files changed, 3 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 2060adf..1ffdf6c 100644 --- a/README.md +++ b/README.md @@ -105,6 +105,7 @@ tox -e debug tests.requests.test_prometheus ``` ## Releasenotes +- 0.15.9 - Fix: read correct attribute for the frequency bands - 0.15.8 - SST/XST: Account for a signal index offset (HBA1) when collecting statistics - 0.15.7 - Fix: Recording LBA statistics does not request HBA-only metadata - Fix: Syntax error when querying SDP metadata diff --git a/VERSION b/VERSION index 1e1a04a..bc300b9 100644 --- a/VERSION +++ b/VERSION @@ -1 +1 @@ -0.15.8 +0.15.9 diff --git a/lofar_station_client/statistics/writer/hdf5.py b/lofar_station_client/statistics/writer/hdf5.py index 15d06a5..2fe29d2 100644 --- a/lofar_station_client/statistics/writer/hdf5.py +++ b/lofar_station_client/statistics/writer/hdf5.py @@ -382,7 +382,7 @@ class HDF5Writer(ABC): if self.antennafield_device.Antenna_Type_R != "LBA": matrix.hbat_pwr_on = self.antennafield_device.HBAT_PWR_on_R - matrix.frequency_band = self.antennafield_device.Frequency_Band_R + matrix.frequency_band = self.antennafield_device.Frequency_Band_RW except (DevFailed, AttributeError): logger.exception( "Failed to read from %s", self.antennafield_device.name() diff --git a/tests/test_devices.py b/tests/test_devices.py index 6a5d212..ef42244 100644 --- a/tests/test_devices.py +++ b/tests/test_devices.py @@ -298,7 +298,6 @@ class FakeAntennaFieldDeviceProxy: RCU_PCB_ID_R = [[1, 1]] * 48 RCU_PCB_version_R = [["version", "version"]] * 48 HBAT_PWR_on_R = [] - Frequency_Band_R = [] def __init__(self, name): self._name = name -- GitLab