diff --git a/pogo/CspSubElementController.xmi b/pogo/CspSubElementController.xmi index 53b9f70bb409b68983016045970e5bef241410b5..c861cbdb54bde0004aa37903408b1df8606b27fa 100644 --- a/pogo/CspSubElementController.xmi +++ b/pogo/CspSubElementController.xmi @@ -381,13 +381,13 @@ <status abstract="false" inherited="true" concrete="true"/> <properties description="Logging targets for this device, excluding ska_ser_logging defaults - 
initialises to LoggingTargetsDefault on startup" label="" unit="" standardUnit="" displayUnit="" format="" maxValue="" minValue="" maxAlarm="" minAlarm="" maxWarning="" minWarning="" deltaTime="" deltaValue=""/> </attributes> - <attributes name="longRunningCommandsInQueue" attType="Spectrum" rwType="READ" displayLevel="OPERATOR" polledPeriod="0" maxX="98" maxY="" allocReadMember="true" isDynamic="false"> + <attributes name="longRunningCommandsInQueue" attType="Spectrum" rwType="READ" displayLevel="OPERATOR" polledPeriod="0" maxX="100" maxY="" allocReadMember="true" isDynamic="false"> <dataType xsi:type="pogoDsl:StringType"/> <changeEvent fire="true" libCheckCriteria="true"/> <status abstract="false" inherited="true" concrete="true" concreteHere="false"/> <properties description="Keep track of which commands are in the queue. 
Pop off from front as they complete." label="" unit="" standardUnit="" displayUnit="" format="" maxValue="" minValue="" maxAlarm="" minAlarm="" maxWarning="" minWarning="" deltaTime="" deltaValue=""/> </attributes> - <attributes name="longRunningCommandIDsInQueue" attType="Spectrum" rwType="READ" displayLevel="OPERATOR" polledPeriod="0" maxX="98" maxY="" allocReadMember="true" isDynamic="false"> + <attributes name="longRunningCommandIDsInQueue" attType="Spectrum" rwType="READ" displayLevel="OPERATOR" polledPeriod="0" maxX="100" maxY="" allocReadMember="true" isDynamic="false"> <dataType xsi:type="pogoDsl:StringType"/> <changeEvent fire="false" libCheckCriteria="false"/> <status abstract="false" inherited="true" concrete="true" concreteHere="false"/> @@ -399,7 +399,7 @@ <status abstract="false" inherited="true" concrete="true" concreteHere="false"/> <properties description="ID, status pair of the currently executing command. 
Clients can subscribe to on_change event and wait for the ID they are interested in." label="" unit="" standardUnit="" displayUnit="" format="" maxValue="" minValue="" maxAlarm="" minAlarm="" maxWarning="" minWarning="" deltaTime="" deltaValue=""/> </attributes> - <attributes name="longRunningCommandProgress" attType="Spectrum" rwType="READ" displayLevel="OPERATOR" polledPeriod="0" maxX="2" maxY="" allocReadMember="true" isDynamic="false"> + <attributes name="longRunningCommandProgress" attType="Spectrum" rwType="READ" displayLevel="OPERATOR" polledPeriod="0" maxX="100" maxY="" allocReadMember="true" isDynamic="false"> <dataType xsi:type="pogoDsl:StringType"/> <changeEvent fire="true" libCheckCriteria="true"/> <status abstract="false" inherited="true" concrete="true" concreteHere="false"/> diff --git a/pogo/CspSubElementObsDevice.xmi b/pogo/CspSubElementObsDevice.xmi index 50fe99215ceb8a0734cff35a05f01e91ca05a9a9..7befab6dceac94b1e8e3f94fc07f58ff46aab16f 100644 --- a/pogo/CspSubElementObsDevice.xmi +++ b/pogo/CspSubElementObsDevice.xmi @@ -286,13 +286,13 @@ <status abstract="false" inherited="false" concrete="true" concreteHere="true"/> <properties description="Flag reporting if the SDP link is active.
True: active
False:down" label="sdpLinkActive" unit="" standardUnit="" displayUnit="" format="" maxValue="" minValue="" maxAlarm="" minAlarm="" maxWarning="" minWarning="" deltaTime="" deltaValue=""/> </attributes> - <attributes name="longRunningCommandsInQueue" attType="Spectrum" rwType="READ" displayLevel="OPERATOR" polledPeriod="0" maxX="98" maxY="" allocReadMember="true" isDynamic="false"> + <attributes name="longRunningCommandsInQueue" attType="Spectrum" rwType="READ" displayLevel="OPERATOR" polledPeriod="0" maxX="100" maxY="" allocReadMember="true" isDynamic="false"> <dataType xsi:type="pogoDsl:StringType"/> <changeEvent fire="true" libCheckCriteria="true"/> <status abstract="false" inherited="true" concrete="true" concreteHere="false"/> <properties description="Keep track of which commands are in the queue. 
Pop off from front as they complete." label="" unit="" standardUnit="" displayUnit="" format="" maxValue="" minValue="" maxAlarm="" minAlarm="" maxWarning="" minWarning="" deltaTime="" deltaValue=""/> </attributes> - <attributes name="longRunningCommandIDsInQueue" attType="Spectrum" rwType="READ" displayLevel="OPERATOR" polledPeriod="0" maxX="98" maxY="" allocReadMember="true" isDynamic="false"> + <attributes name="longRunningCommandIDsInQueue" attType="Spectrum" rwType="READ" displayLevel="OPERATOR" polledPeriod="0" maxX="100" maxY="" allocReadMember="true" isDynamic="false"> <dataType xsi:type="pogoDsl:StringType"/> <changeEvent fire="false" libCheckCriteria="false"/> <status abstract="false" inherited="true" concrete="true" concreteHere="false"/> @@ -304,7 +304,7 @@ <status abstract="false" inherited="true" concrete="true" concreteHere="false"/> <properties description="ID, status pair of the currently executing command. 
Clients can subscribe to on_change event and wait for the ID they are interested in." label="" unit="" standardUnit="" displayUnit="" format="" maxValue="" minValue="" maxAlarm="" minAlarm="" maxWarning="" minWarning="" deltaTime="" deltaValue=""/> </attributes> - <attributes name="longRunningCommandProgress" attType="Spectrum" rwType="READ" displayLevel="OPERATOR" polledPeriod="0" maxX="2" maxY="" allocReadMember="true" isDynamic="false"> + <attributes name="longRunningCommandProgress" attType="Spectrum" rwType="READ" displayLevel="OPERATOR" polledPeriod="0" maxX="100" maxY="" allocReadMember="true" isDynamic="false"> <dataType xsi:type="pogoDsl:StringType"/> <changeEvent fire="true" libCheckCriteria="true"/> <status abstract="false" inherited="true" concrete="true" concreteHere="false"/> diff --git a/pogo/CspSubElementSubarray.xmi b/pogo/CspSubElementSubarray.xmi index 6776b7bf39f78dc183a9e3401b55a28f8efd9b98..489b6908ab263dd26f752aaba5d17c2a405119c1 100644 --- a/pogo/CspSubElementSubarray.xmi +++ b/pogo/CspSubElementSubarray.xmi @@ -436,13 +436,13 @@ <status abstract="false" inherited="false" concrete="true" concreteHere="true"/> <properties description="Flag reporting if the SDP links are active." label="sdpLinkActive" unit="" standardUnit="" displayUnit="" format="" maxValue="" minValue="" maxAlarm="" minAlarm="" maxWarning="" minWarning="" deltaTime="" deltaValue=""/> </attributes> - <attributes name="longRunningCommandsInQueue" attType="Spectrum" rwType="READ" displayLevel="OPERATOR" polledPeriod="0" maxX="98" maxY="" allocReadMember="true" isDynamic="false"> + <attributes name="longRunningCommandsInQueue" attType="Spectrum" rwType="READ" displayLevel="OPERATOR" polledPeriod="0" maxX="100" maxY="" allocReadMember="true" isDynamic="false"> <dataType xsi:type="pogoDsl:StringType"/> <changeEvent fire="true" libCheckCriteria="true"/> <status abstract="false" inherited="true" concrete="true" concreteHere="false"/> <properties description="Keep track of which commands are in the queue. 
Pop off from front as they complete." label="" unit="" standardUnit="" displayUnit="" format="" maxValue="" minValue="" maxAlarm="" minAlarm="" maxWarning="" minWarning="" deltaTime="" deltaValue=""/> </attributes> - <attributes name="longRunningCommandIDsInQueue" attType="Spectrum" rwType="READ" displayLevel="OPERATOR" polledPeriod="0" maxX="98" maxY="" allocReadMember="true" isDynamic="false"> + <attributes name="longRunningCommandIDsInQueue" attType="Spectrum" rwType="READ" displayLevel="OPERATOR" polledPeriod="0" maxX="100" maxY="" allocReadMember="true" isDynamic="false"> <dataType xsi:type="pogoDsl:StringType"/> <changeEvent fire="false" libCheckCriteria="false"/> <status abstract="false" inherited="true" concrete="true" concreteHere="false"/> @@ -454,7 +454,7 @@ <status abstract="false" inherited="true" concrete="true" concreteHere="false"/> <properties description="ID, status pair of the currently executing command. 
Clients can subscribe to on_change event and wait for the ID they are interested in." label="" unit="" standardUnit="" displayUnit="" format="" maxValue="" minValue="" maxAlarm="" minAlarm="" maxWarning="" minWarning="" deltaTime="" deltaValue=""/> </attributes> - <attributes name="longRunningCommandProgress" attType="Spectrum" rwType="READ" displayLevel="OPERATOR" polledPeriod="0" maxX="2" maxY="" allocReadMember="true" isDynamic="false"> + <attributes name="longRunningCommandProgress" attType="Spectrum" rwType="READ" displayLevel="OPERATOR" polledPeriod="0" maxX="100" maxY="" allocReadMember="true" isDynamic="false"> <dataType xsi:type="pogoDsl:StringType"/> <changeEvent fire="true" libCheckCriteria="true"/> <status abstract="false" inherited="true" concrete="true" concreteHere="false"/> diff --git a/pogo/SKAAlarmHandler.xmi b/pogo/SKAAlarmHandler.xmi index ed36c87959c32b6aa6e5fa56e4c33d8b8d35fd74..db01bd184e51687cbe12657178050a89ab9d0a5e 100644 --- a/pogo/SKAAlarmHandler.xmi +++ b/pogo/SKAAlarmHandler.xmi @@ -260,13 +260,13 @@ <status abstract="false" inherited="true" concrete="true"/> <properties description="Logging targets for this device, excluding ska_ser_logging defaults - 
initialises to LoggingTargetsDefault on startup" label="" unit="" standardUnit="" displayUnit="" format="" maxValue="" minValue="" maxAlarm="" minAlarm="" maxWarning="" minWarning="" deltaTime="" deltaValue=""/> </attributes> - <attributes name="longRunningCommandsInQueue" attType="Spectrum" rwType="READ" displayLevel="OPERATOR" polledPeriod="0" maxX="98" maxY="" allocReadMember="true" isDynamic="false"> + <attributes name="longRunningCommandsInQueue" attType="Spectrum" rwType="READ" displayLevel="OPERATOR" polledPeriod="0" maxX="100" maxY="" allocReadMember="true" isDynamic="false"> <dataType xsi:type="pogoDsl:StringType"/> <changeEvent fire="true" libCheckCriteria="true"/> <status abstract="false" inherited="true" concrete="true" concreteHere="false"/> <properties description="Keep track of which commands are in the queue. 
Pop off from front as they complete." label="" unit="" standardUnit="" displayUnit="" format="" maxValue="" minValue="" maxAlarm="" minAlarm="" maxWarning="" minWarning="" deltaTime="" deltaValue=""/> </attributes> - <attributes name="longRunningCommandIDsInQueue" attType="Spectrum" rwType="READ" displayLevel="OPERATOR" polledPeriod="0" maxX="98" maxY="" allocReadMember="true" isDynamic="false"> + <attributes name="longRunningCommandIDsInQueue" attType="Spectrum" rwType="READ" displayLevel="OPERATOR" polledPeriod="0" maxX="100" maxY="" allocReadMember="true" isDynamic="false"> <dataType xsi:type="pogoDsl:StringType"/> <changeEvent fire="false" libCheckCriteria="false"/> <status abstract="false" inherited="true" concrete="true" concreteHere="false"/> @@ -278,7 +278,7 @@ <status abstract="false" inherited="true" concrete="true" concreteHere="false"/> <properties description="ID, status pair of the currently executing command. 
Clients can subscribe to on_change event and wait for the ID they are interested in." label="" unit="" standardUnit="" displayUnit="" format="" maxValue="" minValue="" maxAlarm="" minAlarm="" maxWarning="" minWarning="" deltaTime="" deltaValue=""/> </attributes> - <attributes name="longRunningCommandProgress" attType="Spectrum" rwType="READ" displayLevel="OPERATOR" polledPeriod="0" maxX="2" maxY="" allocReadMember="true" isDynamic="false"> + <attributes name="longRunningCommandProgress" attType="Spectrum" rwType="READ" displayLevel="OPERATOR" polledPeriod="0" maxX="100" maxY="" allocReadMember="true" isDynamic="false"> <dataType xsi:type="pogoDsl:StringType"/> <changeEvent fire="true" libCheckCriteria="true"/> <status abstract="false" inherited="true" concrete="true" concreteHere="false"/> diff --git a/pogo/SKABaseDevice.xmi b/pogo/SKABaseDevice.xmi index 8bba124cfdb36ed5ab4a00d0d434742a999f071a..a7f7ed3d33b5aab3b45766fea89602a568004058 100644 --- a/pogo/SKABaseDevice.xmi +++ b/pogo/SKABaseDevice.xmi @@ -167,13 +167,13 @@ <status abstract="false" inherited="false" concrete="true" concreteHere="true"/> <properties description="Logging targets for this device, excluding ska_ser_logging defaults - 
initialises to LoggingTargetsDefault on startup" label="" unit="" standardUnit="" displayUnit="" format="" maxValue="" minValue="" maxAlarm="" minAlarm="" maxWarning="" minWarning="" deltaTime="" deltaValue=""/> </attributes> - <attributes name="longRunningCommandsInQueue" attType="Spectrum" rwType="READ" displayLevel="OPERATOR" polledPeriod="0" maxX="98" maxY="" allocReadMember="true" isDynamic="false"> + <attributes name="longRunningCommandsInQueue" attType="Spectrum" rwType="READ" displayLevel="OPERATOR" polledPeriod="0" maxX="100" maxY="" allocReadMember="true" isDynamic="false"> <dataType xsi:type="pogoDsl:StringType"/> <changeEvent fire="true" libCheckCriteria="true"/> <status abstract="false" inherited="false" concrete="true" concreteHere="true"/> <properties description="Keep track of which commands are in the queue. 
Pop off from front as they complete." label="" unit="" standardUnit="" displayUnit="" format="" maxValue="" minValue="" maxAlarm="" minAlarm="" maxWarning="" minWarning="" deltaTime="" deltaValue=""/> </attributes> - <attributes name="longRunningCommandIDsInQueue" attType="Spectrum" rwType="READ" displayLevel="OPERATOR" polledPeriod="0" maxX="98" maxY="" allocReadMember="true" isDynamic="false"> + <attributes name="longRunningCommandIDsInQueue" attType="Spectrum" rwType="READ" displayLevel="OPERATOR" polledPeriod="0" maxX="100" maxY="" allocReadMember="true" isDynamic="false"> <dataType xsi:type="pogoDsl:StringType"/> <changeEvent fire="true" libCheckCriteria="true"/> <status abstract="false" inherited="false" concrete="true" concreteHere="true"/> @@ -185,7 +185,7 @@ <status abstract="false" inherited="false" concrete="true" concreteHere="true"/> <properties description="ID, status pair of the currently executing command. 
Clients can subscribe to on_change event and wait for the ID they are interested in." label="" unit="" standardUnit="" displayUnit="" format="" maxValue="" minValue="" maxAlarm="" minAlarm="" maxWarning="" minWarning="" deltaTime="" deltaValue=""/> </attributes> - <attributes name="longRunningCommandProgress" attType="Spectrum" rwType="READ" displayLevel="OPERATOR" polledPeriod="0" maxX="2" maxY="" allocReadMember="true" isDynamic="false"> + <attributes name="longRunningCommandProgress" attType="Spectrum" rwType="READ" displayLevel="OPERATOR" polledPeriod="0" maxX="100" maxY="" allocReadMember="true" isDynamic="false"> <dataType xsi:type="pogoDsl:StringType"/> <changeEvent fire="true" libCheckCriteria="true"/> <status abstract="false" inherited="false" concrete="true" concreteHere="true"/> diff --git a/pogo/SKACapability.xmi b/pogo/SKACapability.xmi index 190595773d2a1f9fc147c8771aee2d6a032cf413..b71acefedfa4738c44587657b2a95208db2102fa 100644 --- a/pogo/SKACapability.xmi +++ b/pogo/SKACapability.xmi @@ -207,13 +207,13 @@ <status abstract="false" inherited="false" concrete="true" concreteHere="true"/> <properties description="A list of components with no. of instances in use on this Capability." label="" unit="" standardUnit="" displayUnit="" format="" maxValue="" minValue="" maxAlarm="" minAlarm="" maxWarning="" minWarning="" deltaTime="" deltaValue=""/> </attributes> - <attributes name="longRunningCommandsInQueue" attType="Spectrum" rwType="READ" displayLevel="OPERATOR" polledPeriod="0" maxX="98" maxY="" allocReadMember="true" isDynamic="false"> + <attributes name="longRunningCommandsInQueue" attType="Spectrum" rwType="READ" displayLevel="OPERATOR" polledPeriod="0" maxX="100" maxY="" allocReadMember="true" isDynamic="false"> <dataType xsi:type="pogoDsl:StringType"/> <changeEvent fire="true" libCheckCriteria="true"/> <status abstract="false" inherited="true" concrete="true" concreteHere="false"/> <properties description="Keep track of which commands are in the queue. 
Pop off from front as they complete." label="" unit="" standardUnit="" displayUnit="" format="" maxValue="" minValue="" maxAlarm="" minAlarm="" maxWarning="" minWarning="" deltaTime="" deltaValue=""/> </attributes> - <attributes name="longRunningCommandIDsInQueue" attType="Spectrum" rwType="READ" displayLevel="OPERATOR" polledPeriod="0" maxX="98" maxY="" allocReadMember="true" isDynamic="false"> + <attributes name="longRunningCommandIDsInQueue" attType="Spectrum" rwType="READ" displayLevel="OPERATOR" polledPeriod="0" maxX="100" maxY="" allocReadMember="true" isDynamic="false"> <dataType xsi:type="pogoDsl:StringType"/> <changeEvent fire="false" libCheckCriteria="false"/> <status abstract="false" inherited="true" concrete="true" concreteHere="false"/> @@ -225,7 +225,7 @@ <status abstract="false" inherited="true" concrete="true" concreteHere="false"/> <properties description="ID, status pair of the currently executing command. 
Clients can subscribe to on_change event and wait for the ID they are interested in." label="" unit="" standardUnit="" displayUnit="" format="" maxValue="" minValue="" maxAlarm="" minAlarm="" maxWarning="" minWarning="" deltaTime="" deltaValue=""/> </attributes> - <attributes name="longRunningCommandProgress" attType="Spectrum" rwType="READ" displayLevel="OPERATOR" polledPeriod="0" maxX="2" maxY="" allocReadMember="true" isDynamic="false"> + <attributes name="longRunningCommandProgress" attType="Spectrum" rwType="READ" displayLevel="OPERATOR" polledPeriod="0" maxX="100" maxY="" allocReadMember="true" isDynamic="false"> <dataType xsi:type="pogoDsl:StringType"/> <changeEvent fire="true" libCheckCriteria="true"/> <status abstract="false" inherited="true" concrete="true" concreteHere="false"/> diff --git a/pogo/SKAController.xmi b/pogo/SKAController.xmi index 1510e695e05ac6f99803c8b723e657d620cb9114..46679e7d55b18d1c0a3fa52b503aaab808362dad 100644 --- a/pogo/SKAController.xmi +++ b/pogo/SKAController.xmi @@ -222,13 +222,13 @@ <properties description="Logging targets for this device, excluding ska_ser_logging defaults - 
initialises to LoggingTargetsDefault on startup" label="" unit="" standardUnit="" displayUnit="" format="" maxValue="" minValue="" maxAlarm="" minAlarm="" maxWarning="" minWarning="" deltaTime="" deltaValue=""/> </attributes> </attributes> - <attributes name="longRunningCommandsInQueue" attType="Spectrum" rwType="READ" displayLevel="OPERATOR" polledPeriod="0" maxX="98" maxY="" allocReadMember="true" isDynamic="false"> + <attributes name="longRunningCommandsInQueue" attType="Spectrum" rwType="READ" displayLevel="OPERATOR" polledPeriod="0" maxX="100" maxY="" allocReadMember="true" isDynamic="false"> <dataType xsi:type="pogoDsl:StringType"/> <changeEvent fire="true" libCheckCriteria="true"/> <status abstract="false" inherited="true" concrete="true" concreteHere="false"/> <properties description="Keep track of which commands are in the queue. 
Pop off from front as they complete." label="" unit="" standardUnit="" displayUnit="" format="" maxValue="" minValue="" maxAlarm="" minAlarm="" maxWarning="" minWarning="" deltaTime="" deltaValue=""/> </attributes> - <attributes name="longRunningCommandIDsInQueue" attType="Spectrum" rwType="READ" displayLevel="OPERATOR" polledPeriod="0" maxX="98" maxY="" allocReadMember="true" isDynamic="false"> + <attributes name="longRunningCommandIDsInQueue" attType="Spectrum" rwType="READ" displayLevel="OPERATOR" polledPeriod="0" maxX="100" maxY="" allocReadMember="true" isDynamic="false"> <dataType xsi:type="pogoDsl:StringType"/> <changeEvent fire="false" libCheckCriteria="false"/> <status abstract="false" inherited="true" concrete="true" concreteHere="false"/> @@ -240,7 +240,7 @@ <status abstract="false" inherited="true" concrete="true" concreteHere="false"/> <properties description="ID, status pair of the currently executing command. 
Clients can subscribe to on_change event and wait for the ID they are interested in." label="" unit="" standardUnit="" displayUnit="" format="" maxValue="" minValue="" maxAlarm="" minAlarm="" maxWarning="" minWarning="" deltaTime="" deltaValue=""/> </attributes> - <attributes name="longRunningCommandProgress" attType="Spectrum" rwType="READ" displayLevel="OPERATOR" polledPeriod="0" maxX="2" maxY="" allocReadMember="true" isDynamic="false"> + <attributes name="longRunningCommandProgress" attType="Spectrum" rwType="READ" displayLevel="OPERATOR" polledPeriod="0" maxX="100" maxY="" allocReadMember="true" isDynamic="false"> <dataType xsi:type="pogoDsl:StringType"/> <changeEvent fire="true" libCheckCriteria="true"/> <status abstract="false" inherited="true" concrete="true" concreteHere="false"/> diff --git a/pogo/SKALogger.xmi b/pogo/SKALogger.xmi index 33be429b1ab2762ac12893143956475482951539..267dbfb092f18f98b15fad112d09289811805fa7 100644 --- a/pogo/SKALogger.xmi +++ b/pogo/SKALogger.xmi @@ -148,13 +148,13 @@ <status abstract="false" inherited="true" concrete="true"/> <properties description="Logging targets for this device, excluding ska_ser_logging defaults - 
initialises to LoggingTargetsDefault on startup" label="" unit="" standardUnit="" displayUnit="" format="" maxValue="" minValue="" maxAlarm="" minAlarm="" maxWarning="" minWarning="" deltaTime="" deltaValue=""/> </attributes> - <attributes name="longRunningCommandsInQueue" attType="Spectrum" rwType="READ" displayLevel="OPERATOR" polledPeriod="0" maxX="98" maxY="" allocReadMember="true" isDynamic="false"> + <attributes name="longRunningCommandsInQueue" attType="Spectrum" rwType="READ" displayLevel="OPERATOR" polledPeriod="0" maxX="100" maxY="" allocReadMember="true" isDynamic="false"> <dataType xsi:type="pogoDsl:StringType"/> <changeEvent fire="true" libCheckCriteria="true"/> <status abstract="false" inherited="true" concrete="true" concreteHere="false"/> <properties description="Keep track of which commands are in the queue. 
Pop off from front as they complete." label="" unit="" standardUnit="" displayUnit="" format="" maxValue="" minValue="" maxAlarm="" minAlarm="" maxWarning="" minWarning="" deltaTime="" deltaValue=""/> </attributes> - <attributes name="longRunningCommandIDsInQueue" attType="Spectrum" rwType="READ" displayLevel="OPERATOR" polledPeriod="0" maxX="98" maxY="" allocReadMember="true" isDynamic="false"> + <attributes name="longRunningCommandIDsInQueue" attType="Spectrum" rwType="READ" displayLevel="OPERATOR" polledPeriod="0" maxX="100" maxY="" allocReadMember="true" isDynamic="false"> <dataType xsi:type="pogoDsl:StringType"/> <changeEvent fire="false" libCheckCriteria="false"/> <status abstract="false" inherited="true" concrete="true" concreteHere="false"/> @@ -166,7 +166,7 @@ <status abstract="false" inherited="true" concrete="true" concreteHere="false"/> <properties description="ID, status pair of the currently executing command. 
Clients can subscribe to on_change event and wait for the ID they are interested in." label="" unit="" standardUnit="" displayUnit="" format="" maxValue="" minValue="" maxAlarm="" minAlarm="" maxWarning="" minWarning="" deltaTime="" deltaValue=""/> </attributes> - <attributes name="longRunningCommandProgress" attType="Spectrum" rwType="READ" displayLevel="OPERATOR" polledPeriod="0" maxX="2" maxY="" allocReadMember="true" isDynamic="false"> + <attributes name="longRunningCommandProgress" attType="Spectrum" rwType="READ" displayLevel="OPERATOR" polledPeriod="0" maxX="100" maxY="" allocReadMember="true" isDynamic="false"> <dataType xsi:type="pogoDsl:StringType"/> <changeEvent fire="true" libCheckCriteria="true"/> <status abstract="false" inherited="true" concrete="true" concreteHere="false"/> diff --git a/pogo/SKAObsDevice.xmi b/pogo/SKAObsDevice.xmi index 658364ddfc4d4e82ae4e5ef0fdacde8d67322e31..3512f14737da381a38d4b94adb0fafb894e6406b 100644 --- a/pogo/SKAObsDevice.xmi +++ b/pogo/SKAObsDevice.xmi @@ -186,13 +186,13 @@ <status abstract="false" inherited="true" concrete="true"/> <properties description="Logging targets for this device, excluding ska_ser_logging defaults - 
initialises to LoggingTargetsDefault on startup" label="" unit="" standardUnit="" displayUnit="" format="" maxValue="" minValue="" maxAlarm="" minAlarm="" maxWarning="" minWarning="" deltaTime="" deltaValue=""/> </attributes> - <attributes name="longRunningCommandsInQueue" attType="Spectrum" rwType="READ" displayLevel="OPERATOR" polledPeriod="0" maxX="98" maxY="" allocReadMember="true" isDynamic="false"> + <attributes name="longRunningCommandsInQueue" attType="Spectrum" rwType="READ" displayLevel="OPERATOR" polledPeriod="0" maxX="100" maxY="" allocReadMember="true" isDynamic="false"> <dataType xsi:type="pogoDsl:StringType"/> <changeEvent fire="true" libCheckCriteria="true"/> <status abstract="false" inherited="true" concrete="true" concreteHere="false"/> <properties description="Keep track of which commands are in the queue. 
Pop off from front as they complete." label="" unit="" standardUnit="" displayUnit="" format="" maxValue="" minValue="" maxAlarm="" minAlarm="" maxWarning="" minWarning="" deltaTime="" deltaValue=""/> </attributes> - <attributes name="longRunningCommandIDsInQueue" attType="Spectrum" rwType="READ" displayLevel="OPERATOR" polledPeriod="0" maxX="98" maxY="" allocReadMember="true" isDynamic="false"> + <attributes name="longRunningCommandIDsInQueue" attType="Spectrum" rwType="READ" displayLevel="OPERATOR" polledPeriod="0" maxX="100" maxY="" allocReadMember="true" isDynamic="false"> <dataType xsi:type="pogoDsl:StringType"/> <changeEvent fire="false" libCheckCriteria="false"/> <status abstract="false" inherited="true" concrete="true" concreteHere="false"/> @@ -204,7 +204,7 @@ <status abstract="false" inherited="true" concrete="true" concreteHere="false"/> <properties description="ID, status pair of the currently executing command. 
Clients can subscribe to on_change event and wait for the ID they are interested in." label="" unit="" standardUnit="" displayUnit="" format="" maxValue="" minValue="" maxAlarm="" minAlarm="" maxWarning="" minWarning="" deltaTime="" deltaValue=""/> </attributes> - <attributes name="longRunningCommandProgress" attType="Spectrum" rwType="READ" displayLevel="OPERATOR" polledPeriod="0" maxX="2" maxY="" allocReadMember="true" isDynamic="false"> + <attributes name="longRunningCommandProgress" attType="Spectrum" rwType="READ" displayLevel="OPERATOR" polledPeriod="0" maxX="100" maxY="" allocReadMember="true" isDynamic="false"> <dataType xsi:type="pogoDsl:StringType"/> <changeEvent fire="true" libCheckCriteria="true"/> <status abstract="false" inherited="true" concrete="true" concreteHere="false"/> diff --git a/pogo/SKASubarray.xmi b/pogo/SKASubarray.xmi index 610fbc7a15288d0dca24cd84ba1a81a7019d01cb..f13224cf3843b06f84b9c7c66a3d9ab52546f98b 100644 --- a/pogo/SKASubarray.xmi +++ b/pogo/SKASubarray.xmi @@ -284,13 +284,13 @@ <status abstract="false" inherited="true" concrete="true"/> <properties description="Logging targets for this device, excluding ska_ser_logging defaults - 
initialises to LoggingTargetsDefault on startup" label="" unit="" standardUnit="" displayUnit="" format="" maxValue="" minValue="" maxAlarm="" minAlarm="" maxWarning="" minWarning="" deltaTime="" deltaValue=""/> </attributes> - <attributes name="longRunningCommandsInQueue" attType="Spectrum" rwType="READ" displayLevel="OPERATOR" polledPeriod="0" maxX="98" maxY="" allocReadMember="true" isDynamic="false"> + <attributes name="longRunningCommandsInQueue" attType="Spectrum" rwType="READ" displayLevel="OPERATOR" polledPeriod="0" maxX="100" maxY="" allocReadMember="true" isDynamic="false"> <dataType xsi:type="pogoDsl:StringType"/> <changeEvent fire="true" libCheckCriteria="true"/> <status abstract="false" inherited="true" concrete="true" concreteHere="false"/> <properties description="Keep track of which commands are in the queue. 
Pop off from front as they complete." label="" unit="" standardUnit="" displayUnit="" format="" maxValue="" minValue="" maxAlarm="" minAlarm="" maxWarning="" minWarning="" deltaTime="" deltaValue=""/> </attributes> - <attributes name="longRunningCommandIDsInQueue" attType="Spectrum" rwType="READ" displayLevel="OPERATOR" polledPeriod="0" maxX="98" maxY="" allocReadMember="true" isDynamic="false"> + <attributes name="longRunningCommandIDsInQueue" attType="Spectrum" rwType="READ" displayLevel="OPERATOR" polledPeriod="0" maxX="100" maxY="" allocReadMember="true" isDynamic="false"> <dataType xsi:type="pogoDsl:StringType"/> <changeEvent fire="false" libCheckCriteria="false"/> <status abstract="false" inherited="true" concrete="true" concreteHere="false"/> @@ -302,7 +302,7 @@ <status abstract="false" inherited="true" concrete="true" concreteHere="false"/> <properties description="ID, status pair of the currently executing command. 
Clients can subscribe to on_change event and wait for the ID they are interested in." label="" unit="" standardUnit="" displayUnit="" format="" maxValue="" minValue="" maxAlarm="" minAlarm="" maxWarning="" minWarning="" deltaTime="" deltaValue=""/> </attributes> - <attributes name="longRunningCommandProgress" attType="Spectrum" rwType="READ" displayLevel="OPERATOR" polledPeriod="0" maxX="2" maxY="" allocReadMember="true" isDynamic="false"> + <attributes name="longRunningCommandProgress" attType="Spectrum" rwType="READ" displayLevel="OPERATOR" polledPeriod="0" maxX="100" maxY="" allocReadMember="true" isDynamic="false"> <dataType xsi:type="pogoDsl:StringType"/> <changeEvent fire="true" libCheckCriteria="true"/> <status abstract="false" inherited="true" concrete="true" concreteHere="false"/> diff --git a/pogo/SKATelState.xmi b/pogo/SKATelState.xmi index 3e5124984c60d0bf46a776aba34f3f32b6f66eea..009fed6b9224161dd27335abf828212d706e4023 100644 --- a/pogo/SKATelState.xmi +++ b/pogo/SKATelState.xmi @@ -143,13 +143,13 @@ <status abstract="false" inherited="true" concrete="true"/> <properties description="Logging targets for this device, excluding ska_ser_logging defaults - 
initialises to LoggingTargetsDefault on startup" label="" unit="" standardUnit="" displayUnit="" format="" maxValue="" minValue="" maxAlarm="" minAlarm="" maxWarning="" minWarning="" deltaTime="" deltaValue=""/> </attributes> - <attributes name="longRunningCommandsInQueue" attType="Spectrum" rwType="READ" displayLevel="OPERATOR" polledPeriod="0" maxX="98" maxY="" allocReadMember="true" isDynamic="false"> + <attributes name="longRunningCommandsInQueue" attType="Spectrum" rwType="READ" displayLevel="OPERATOR" polledPeriod="0" maxX="100" maxY="" allocReadMember="true" isDynamic="false"> <dataType xsi:type="pogoDsl:StringType"/> <changeEvent fire="true" libCheckCriteria="true"/> <status abstract="false" inherited="true" concrete="true" concreteHere="false"/> <properties description="Keep track of which commands are in the queue. 
Pop off from front as they complete." label="" unit="" standardUnit="" displayUnit="" format="" maxValue="" minValue="" maxAlarm="" minAlarm="" maxWarning="" minWarning="" deltaTime="" deltaValue=""/> </attributes> - <attributes name="longRunningCommandIDsInQueue" attType="Spectrum" rwType="READ" displayLevel="OPERATOR" polledPeriod="0" maxX="98" maxY="" allocReadMember="true" isDynamic="false"> + <attributes name="longRunningCommandIDsInQueue" attType="Spectrum" rwType="READ" displayLevel="OPERATOR" polledPeriod="0" maxX="100" maxY="" allocReadMember="true" isDynamic="false"> <dataType xsi:type="pogoDsl:StringType"/> <changeEvent fire="false" libCheckCriteria="false"/> <status abstract="false" inherited="true" concrete="true" concreteHere="false"/> @@ -161,7 +161,7 @@ <status abstract="false" inherited="true" concrete="true" concreteHere="false"/> <properties description="ID, status pair of the currently executing command. 
Clients can subscribe to on_change event and wait for the ID they are interested in." label="" unit="" standardUnit="" displayUnit="" format="" maxValue="" minValue="" maxAlarm="" minAlarm="" maxWarning="" minWarning="" deltaTime="" deltaValue=""/> </attributes> - <attributes name="longRunningCommandProgress" attType="Spectrum" rwType="READ" displayLevel="OPERATOR" polledPeriod="0" maxX="2" maxY="" allocReadMember="true" isDynamic="false"> + <attributes name="longRunningCommandProgress" attType="Spectrum" rwType="READ" displayLevel="OPERATOR" polledPeriod="0" maxX="100" maxY="" allocReadMember="true" isDynamic="false"> <dataType xsi:type="pogoDsl:StringType"/> <changeEvent fire="true" libCheckCriteria="true"/> <status abstract="false" inherited="true" concrete="true" concreteHere="false"/> diff --git a/src/ska_tango_base/base/base_device.py b/src/ska_tango_base/base/base_device.py index 9e3d71f1052cfc83235b07dab7e161848d928572..e19c99a778a11ea987e09820e4cba488de044ef6 100644 --- a/src/ska_tango_base/base/base_device.py +++ b/src/ska_tango_base/base/base_device.py @@ -699,7 +699,7 @@ class SKABaseDevice(Device): longRunningCommandsInQueue = attribute( dtype=("str",), - max_dim_x=98, + max_dim_x=100, # Assume we'll never have more than 100 tasks in the queue access=AttrWriteType.READ, doc="Keep track of which commands are in the queue. \n" "Pop off from front as they complete.", @@ -708,7 +708,7 @@ class SKABaseDevice(Device): longRunningCommandIDsInQueue = attribute( dtype=("str",), - max_dim_x=98, + max_dim_x=100, # Assume we'll never have more than 100 tasks in the queue access=AttrWriteType.READ, doc="Every client that executes a command will receive a command ID as response. \n" "Keep track of IDs in the queue. Pop off from front as they complete.", @@ -726,7 +726,7 @@ class SKABaseDevice(Device): longRunningCommandProgress = attribute( dtype=("str",), - max_dim_x=2, + max_dim_x=100, # 2 per thread, assume we'll never do more than 50 threads access=AttrWriteType.READ, doc="ID, progress of the currently executing command. \n" "Clients can subscribe to on_change event and wait for the ID they are interested in..", @@ -735,7 +735,7 @@ class SKABaseDevice(Device): longRunningCommandResult = attribute( dtype=("str",), - max_dim_x=3, + max_dim_x=3, # Always the last result (unique_id, result_code, task_result) access=AttrWriteType.READ, doc="ID, result pair. \n" "Clients can subscribe to on_change event and wait for the ID they are interested in.", diff --git a/src/ska_tango_base/base/task_queue_manager.py b/src/ska_tango_base/base/task_queue_manager.py index d5d5913ce5ab1efeb4bfda321e869928bcc9547b..82490ec15bca8dfb52ded4c2a137a9a4c25f73b8 100644 --- a/src/ska_tango_base/base/task_queue_manager.py +++ b/src/ska_tango_base/base/task_queue_manager.py @@ -555,22 +555,26 @@ class QueueManager: return self._task_result @property - def task_ids_in_queue(self) -> list: + def task_ids_in_queue( + self, + ) -> Tuple[str,]: # noqa: E231 """Task IDs in the queue. :return: The task IDs in the queue - :rtype: list + :rtype: tuple """ - return list(self._tasks_in_queue.keys()) + return tuple(self._tasks_in_queue.keys()) @property - def tasks_in_queue(self) -> list: + def tasks_in_queue( + self, + ) -> Tuple[str,]: # noqa: E231 """Task names in the queue. :return: The list of task names in the queue - :rtype: list + :rtype: tuple """ - return list(self._tasks_in_queue.values()) + return tuple(self._tasks_in_queue.values()) @property def task_status( diff --git a/tests/test_reference_base_device.py b/tests/test_reference_base_device.py index cf62c30744c86e2929b5349e71be3e63962468b6..27b56cfef4d3fc4bf8548f2127d9d4acf74bf482 100644 --- a/tests/test_reference_base_device.py +++ b/tests/test_reference_base_device.py @@ -129,7 +129,7 @@ def test_callbacks(): # longRunningCommandsInQueue attribute_values = [arg[1] for arg in called_args] assert len(attribute_values[0]) == 1 - assert attribute_values[0] == ["ProgressTask"] + assert attribute_values[0] == ("ProgressTask",) # longRunningCommandIDsInQueue assert len(attribute_values[1]) == 1 diff --git a/tests/test_task_queue_manager.py b/tests/test_task_queue_manager.py index 974e4d2411c4e10746a7d93efc3fbe5f9373cc53..f3fa032b6ea63fb0ec0f20166e2feb096f29ac7b 100644 --- a/tests/test_task_queue_manager.py +++ b/tests/test_task_queue_manager.py @@ -475,7 +475,7 @@ class TestComponentManager: """Test that we can init the component manager.""" qm = QueueManager(max_queue_size=0, num_workers=1, logger=logger) cm = BaseComponentManager(op_state_model=None, queue_manager=qm, logger=logger) - assert cm.queue_manager.task_ids_in_queue == [] + assert cm.queue_manager.task_ids_in_queue == () class TestStress: