diff --git a/README.md b/README.md index 75541560b847d4e37553fd612b67f523e1bd9fd1..cd8bc1314002d87e95ddb86444bfd61b4722a0be 100644 --- a/README.md +++ b/README.md @@ -252,7 +252,7 @@ is set, we internally update the TLS logging level as well. ### Additional logging targets -Note that the the `loggingTargets` attribute says "excluding ska_logging defaults". +Note that the `loggingTargets` attribute says "excluding ska_logging defaults". Even when empty, you will still have the logging to stdout that is already provided by the ska_logging library. If you want to forward logs to other targets, then you can use this attribute. Since we also want logging to TLS, it should include the `"tango::logger"` @@ -325,7 +325,7 @@ method from an instance of a `tango.DeviceProxy` object. If you want file and syslog targets, you could do something like: `proxy.loggingTargets = ["file::/tmp/my.log", "syslog::udp://server.domain:514"]`. -**Note:** There is a limit of 4 additional handlers. That the maximum length +**Note:** There is a limit of 4 additional handlers. That is the maximum length of the spectrum attribute. We could change this if there is a reasonable use case for it. diff --git a/tests/test_base_device.py b/tests/test_base_device.py index a4ede7cca6504549e44834940f75399737277472..d220092b03409b966a7c9483b888fb67d36bbf71 100644 --- a/tests/test_base_device.py +++ b/tests/test_base_device.py @@ -443,7 +443,7 @@ class TestSKABaseDevice(object): mocked_creator.side_effect = null_creator - # test adding console target + # test console target tango_context.device.loggingTargets = ["console::cout"] assert tango_context.device.loggingTargets == ("console::cout", ) mocked_creator.assert_called_once_with("console::cout", mock.ANY)