ASTRON SDC issueshttps://git.astron.nl/groups/astron-sdc/-/issues2024-01-23T09:43:43Zhttps://git.astron.nl/astron-sdc/stageit/-/issues/3Move tests to correct tests folder2024-01-23T09:43:43ZKlaas Kliffenkliffen@astron.nlMove tests to correct tests folderMost tests are now in the stage_api app. Probably some of them should be moved to the stageit_ui appMost tests are now in the stage_api app. Probably some of them should be moved to the stageit_ui appKlaas Kliffenkliffen@astron.nlKlaas Kliffenkliffen@astron.nlhttps://git.astron.nl/astron-sdc/astronauth/-/issues/9Update docs with settings for OIDC prefix.2024-01-08T08:43:14ZKlaas Kliffenkliffen@astron.nlUpdate docs with settings for OIDC prefix.https://docs.allauth.org/en/latest/release-notes/recent.html#backwards-incompatible-changes
In version 0.60 of allauth, the OIDC login url has been changed. Either the URL's in Keycloak need updating, or we need to set for each app the ...https://docs.allauth.org/en/latest/release-notes/recent.html#backwards-incompatible-changes
In version 0.60 of allauth, the OIDC login url has been changed. Either the URL's in Keycloak need updating, or we need to set for each app the prefix to `SOCIALACCOUNT_OPENID_CONNECT_URL_PREFIX = ""` instead.Klaas Kliffenkliffen@astron.nlKlaas Kliffenkliffen@astron.nlhttps://git.astron.nl/astron-sdc/escape-wp5/esap-general/-/issues/211Rucio URL needs to be configured in two places2023-07-12T12:31:21ZYan GrangeRucio URL needs to be configured in two placesWhen I set up my own ESAP that needs to talk to its own Rucio instance, I have to configure the URL both in the envrionment through the RUCIO_HOST and RUCIO_AUTH_HOST as well as in the `esap/esap/esap_config.yaml` file which contains a `...When I set up my own ESAP that needs to talk to its own Rucio instance, I have to configure the URL both in the envrionment through the RUCIO_HOST and RUCIO_AUTH_HOST as well as in the `esap/esap/esap_config.yaml` file which contains a `url` and a `user_url`. This is not really documented and may lead to some weird errors because the URL used to list the scopes is taken from the environment while the URL that is used to find the files within a scope is taken from the latter.
I am looking into this so I may propose a fix today.https://git.astron.nl/astron-sdc/ldv-specification/-/issues/3Make deployment to test and prod parrallel instead of sequential.2023-06-09T09:07:11ZKlaas Kliffenkliffen@astron.nlMake deployment to test and prod parrallel instead of sequential.Now you have to first deploy to test before you can deploy to production, while it already should have been tested/deployed to production in an MR.Now you have to first deploy to test before you can deploy to production, while it already should have been tested/deployed to production in an MR.https://git.astron.nl/astron-sdc/escape-wp5/esap-general/-/issues/210Make OIDC audience configurable2023-07-12T12:31:21ZYan GrangeMake OIDC audience configurableWhen trying to connect ESAP to the SKAO Rucio, this failed because the `aud` of the OIDC request is expected to be slightly different in this case. This is an extension of the original aud (adding an extra `https://wlcg.cern.ch/jwt/v1/an...When trying to connect ESAP to the SKAO Rucio, this failed because the `aud` of the OIDC request is expected to be slightly different in this case. This is an extension of the original aud (adding an extra `https://wlcg.cern.ch/jwt/v1/any` to it, but I think it may be nicer to make this configurable using an environment variable.https://git.astron.nl/astron-sdc/stageit/-/issues/2Update deployment to match the Django template2023-04-17T12:42:20ZKlaas Kliffenkliffen@astron.nlUpdate deployment to match the Django templateStageit currently uses Nginx and is the "odd-duck" in our coup of services. To bring it more inline with the rest of our services, Django should be configured to host the static files (since we are not "high traffic") and only use Traefi...Stageit currently uses Nginx and is the "odd-duck" in our coup of services. To bring it more inline with the rest of our services, Django should be configured to host the static files (since we are not "high traffic") and only use Traefik as the proxy instead of having multiple layered proxies.https://git.astron.nl/astron-sdc/astronauth/-/issues/8Document email verification2023-04-05T12:59:56ZKlaas Kliffenkliffen@astron.nlDocument email verificationBy default email verification is optional, however, most of our services don't have email verification enabled. Document that this can be set to 'none' to prevent error pages.
See: https://django-allauth.readthedocs.io/en/latest/configu...By default email verification is optional, however, most of our services don't have email verification enabled. Document that this can be set to 'none' to prevent error pages.
See: https://django-allauth.readthedocs.io/en/latest/configuration.html `ACCOUNT_EMAIL_VERIFICATION`Klaas Kliffenkliffen@astron.nlKlaas Kliffenkliffen@astron.nlhttps://git.astron.nl/astron-sdc/astronauth/-/issues/7Add keycloak app to settings.py2023-04-05T12:57:37ZKlaas Kliffenkliffen@astron.nlAdd keycloak app to settings.pyIt is possible to specify Keycloak config (url, client_id and secret) already in the settings.py. See usage for SRAM in: https://git.astron.nl/astron-sdc/propostart/-/merge_requests/3
Also update the docs with the required environment v...It is possible to specify Keycloak config (url, client_id and secret) already in the settings.py. See usage for SRAM in: https://git.astron.nl/astron-sdc/propostart/-/merge_requests/3
Also update the docs with the required environment variables.Klaas Kliffenkliffen@astron.nlKlaas Kliffenkliffen@astron.nlhttps://git.astron.nl/astron-sdc/astronauth/-/issues/6Implement all pages from Allauth2023-04-05T12:55:09ZKlaas Kliffenkliffen@astron.nlImplement all pages from AllauthSee https://django-allauth.readthedocs.io/en/latest/views.html for all available views.
Especially the social connections page might be of interest.See https://django-allauth.readthedocs.io/en/latest/views.html for all available views.
Especially the social connections page might be of interest.https://git.astron.nl/astron-sdc/ldv-specification/-/issues/2Removed field from group does not propagate to workspecifications.2023-04-03T09:00:20ZKlaas Kliffenkliffen@astron.nlRemoved field from group does not propagate to workspecifications.If a field is set to "all" or left empty, it does not propagate to the underlying WS belonging to that group.
This is due to the fact, it is not "present" in the JSON and thus not iterated over (it does not know, if it was there initiall...If a field is set to "all" or left empty, it does not propagate to the underlying WS belonging to that group.
This is due to the fact, it is not "present" in the JSON and thus not iterated over (it does not know, if it was there initially or never there).Klaas Kliffenkliffen@astron.nlKlaas Kliffenkliffen@astron.nlhttps://git.astron.nl/astron-sdc/ldv-specification/-/issues/1Add migrate to Pipeline steps2023-03-30T12:44:52ZKlaas Kliffenkliffen@astron.nlAdd migrate to Pipeline stepsCurrently needs manual interaction to perform migrationsCurrently needs manual interaction to perform migrationsKlaas Kliffenkliffen@astron.nlKlaas Kliffenkliffen@astron.nlhttps://git.astron.nl/astron-sdc/astronauth/-/issues/3Remove hardcoded check for login url to only show login button on non-login p...2023-02-06T11:44:13ZKlaas Kliffenkliffen@astron.nlRemove hardcoded check for login url to only show login button on non-login pagesCurrently we only want to show the login button on non-login pages, to prevent confusion on which buttons to press.
The check is currently hardcoded, should look into a template tag or some other mechanism which can use the `reverse` fun...Currently we only want to show the login button on non-login pages, to prevent confusion on which buttons to press.
The check is currently hardcoded, should look into a template tag or some other mechanism which can use the `reverse` function to get the correct url for the login-view.Klaas Kliffenkliffen@astron.nlKlaas Kliffenkliffen@astron.nlhttps://git.astron.nl/astron-sdc/stageit/-/issues/1Use signal instead of Adapter to create UserInfo and ProjectRole objects2023-02-01T08:25:21ZKlaas Kliffenkliffen@astron.nlUse signal instead of Adapter to create UserInfo and ProjectRole objectsWe don't change anything in the `user` model, we only want to create new objects (for admin purposes). Maybe we should just add a singal: https://django-allauth.readthedocs.io/en/latest/signals.html#allauth-socialaccount (also see here: ...We don't change anything in the `user` model, we only want to create new objects (for admin purposes). Maybe we should just add a singal: https://django-allauth.readthedocs.io/en/latest/signals.html#allauth-socialaccount (also see here: https://docs.djangoproject.com/en/4.1/topics/signals/)https://git.astron.nl/astron-sdc/escape-wp5/esap-general/-/issues/209Zooniverse connector returns invalid results2023-01-23T15:45:36ZKlaas Kliffenkliffen@astron.nlZooniverse connector returns invalid resultsWhen credentials are provided, the Zooniverse connector should only return your own datasets, instead it returns all datasets.When credentials are provided, the Zooniverse connector should only return your own datasets, instead it returns all datasets.Hugh DickinsonHugh Dickinsonhttps://git.astron.nl/astron-sdc/escape-wp5/esap-general/-/issues/208Apply the react rules of hooks in a correct way in ESAP GUI2023-02-27T15:16:06ZKlaas Kliffenkliffen@astron.nlApply the react rules of hooks in a correct way in ESAP GUICurrently some `useEffect` hooks don't have the correct dependencies (https://blog.logrocket.com/understanding-react-exhaustive-deps-linting-warning/) The linting has been disabled for them since they require a major refactoring (both st...Currently some `useEffect` hooks don't have the correct dependencies (https://blog.logrocket.com/understanding-react-exhaustive-deps-linting-warning/) The linting has been disabled for them since they require a major refactoring (both structural and application logic).
See the `FIXME` from this MR: https://git.astron.nl/astron-sdc/escape-wp5/esap-gui/-/merge_requests/109
The major failure mode is an infinite render loop, which is caused by circular updates, where a (re-)render triggers an update. This should not happen in React as state should always flow down and render should be idempotent.https://git.astron.nl/astron-sdc/escape-wp5/esap-general/-/issues/207There is no IDA Service Category documentation2023-01-16T19:12:14ZJohn SwinbankThere is no IDA Service Category documentationThere's a page for it at https://git.astron.nl/astron-sdc/escape-wp5/esap-api-gateway/-/wikis/Service-Categories/Interactive-Analysis-Service-Category, but it is disappointingly empty.There's a page for it at https://git.astron.nl/astron-sdc/escape-wp5/esap-api-gateway/-/wikis/Service-Categories/Interactive-Analysis-Service-Category, but it is disappointingly empty.https://git.astron.nl/astron-sdc/escape-wp5/esap-general/-/issues/206Remove unused Rucio App in ESAP API GW2023-01-16T15:06:54ZKlaas Kliffenkliffen@astron.nlRemove unused Rucio App in ESAP API GWThe django app is not used and can be removed to avoid confusion with the Rucio in the query app.The django app is not used and can be removed to avoid confusion with the Rucio in the query app.https://git.astron.nl/astron-sdc/escape-wp5/esap-general/-/issues/205GUI freezes on Interactive Processing tab when selecting DLaaS without any DL...2023-01-16T08:21:34ZKlaas Kliffenkliffen@astron.nlGUI freezes on Interactive Processing tab when selecting DLaaS without any DLaaS configured in ESAP APITrying to access `response.data.results[0]` on `Interactive.js:189` which is `undefined` in case no DLaaS is configured in ESAP API.Trying to access `response.data.results[0]` on `Interactive.js:189` which is `undefined` in case no DLaaS is configured in ESAP API.https://git.astron.nl/astron-sdc/escape-wp5/esap-general/-/issues/204Apertif Collections “Imaging” or “Timedomain” query fails2023-01-07T11:36:39ZJohn SwinbankApertif Collections “Imaging” or “Timedomain” query failsIf I go to https://sdc-dev.astron.nl/esap-gui/archives/apertif/query and set “Apertif Collections” equal to “Imaging” before hitting submit, I get the message:
```
138, ["Error: ''collection''. Could not translate key: 'collection' for ...If I go to https://sdc-dev.astron.nl/esap-gui/archives/apertif/query and set “Apertif Collections” equal to “Imaging” before hitting submit, I get the message:
```
138, ["Error: ''collection''. Could not translate key: 'collection' for value: 'imaging'. Available translation parameters: {'target': 'target__icontains', 'title': 'target__icontains', 'ra': 'view_ra', 'dec': 'view_dec', 'fov': 'view_fov', 'dataproduct_level': 'calibrationLevel', 'dataproduct_type': 'dataProductType', 'dataproduct_subtype': 'dataProductSubT_and_dataProductSubType__in=uncalibratedVisibility_and_page_size=50"]
```
(and similarly for collection “Timedomain”).
If I set collections to “All” the query works as expected.https://git.astron.nl/astron-sdc/escape-wp5/esap-general/-/issues/202Update react-router-dom for ESAP GUI to version 62022-11-09T08:58:48ZKlaas Kliffenkliffen@astron.nlUpdate react-router-dom for ESAP GUI to version 6Currently we are using version 5. It requires some rework in the code: https://dev.to/arunavamodak/react-router-v5-vs-v6-dp0Currently we are using version 5. It requires some rework in the code: https://dev.to/arunavamodak/react-router-v5-vs-v6-dp0