Klaas Kliffen (a0dd68be) at 25 Jan 10:15
An initial version showcasing async query capabilities using VO TAP services
Overview of current tasks with clickable link for a job detail view. Below the list is a list of buttons to create a new job.
Example form for specifying parameters:
Klaas Kliffen (3f60df03) at 25 Jan 10:15
Merge branch '203_demo_async_vo_query' into 'main'
... and 7 more commits
An initial version showcasing async query capabilities using VO TAP services
Overview of current tasks with clickable link for a job detail view. Below the list is a list of buttons to create a new job.
Example form for specifying parameters:
Klaas Kliffen (a0dd68be) at 25 Jan 10:13
Fix tests
Klaas Kliffen (47988455) at 25 Jan 10:12
Fix casing
Oki. But again for 'load_job': https://i.ytimg.com/vi/KpauQxoH-5M/maxresdefault.jpg
Klaas Kliffen (761ac2b4) at 24 Jan 11:03
Process review
Oh, while at it, took some time to add a small test suite for the util function for the reduce (to make sure it works).
Thanks for the review again
Done!
The EMPTY_JOB_LIST was actually removed, it's now handled by the table (to prevent inconsistent layout). Could probably add more stuff, such as placeholders during loading there, but alas, that might be for V1.1)
It's part of the load_job
function. I rather not put another level of indirection in here.
Extracted into JobTypes.js
Extracted it into JobTypes.js
. Used Object.freeze
to make it immutable. I don't think JS supports Enum classes (they do exist in Typescript).
I did this on purpose, so you might want to add some props or function/handlers to the component. However I see I did not use that for the create Components (I did use it for the detail component).
ACtually, this result in the following error: Warning: Functions are not valid as a React child. This may happen if you return a Component instead of <Component /> from render. Or maybe you meant to call this function rather than return it.
Instead of putting return JOB_TYPES[type].createComponent()
; in there; I prefer to use the "regular" JSX syntax.
Fixed that and documentation everywhere.
Good catch. It has been extracted to util.js
The line has been converted to a function in util.js
and documented.