From ea62d52afb62c63ad77023f32d7be9b7aef7cb1a Mon Sep 17 00:00:00 2001
From: vermaas <vermaas@astron.nl>
Date: Mon, 28 Nov 2022 08:18:14 +0100
Subject: [PATCH] add quality field to quality details view, and make sure to
 save the tasks after changing quality

---
 atdb/taskdatabase/services/algorithms.py | 1 +
 atdb/taskdatabase/views.py               | 9 ++-------
 2 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/atdb/taskdatabase/services/algorithms.py b/atdb/taskdatabase/services/algorithms.py
index 3d241397..7a1a6e8c 100644
--- a/atdb/taskdatabase/services/algorithms.py
+++ b/atdb/taskdatabase/services/algorithms.py
@@ -117,6 +117,7 @@ def convert_quality_to_html(task):
         results += "<tr><td><b>SAS_ID</b></td><td>" + str(task.sas_id) + "</td></tr>"
         results += "<tr><td><b>Project</b></td><td>" + str(task.project) + "</td></tr>"
         results += "<tr><td><b>ATDB Filter</b></td><td>" + str(task.filter) + "</td></tr>"
+        results += "<tr><td><b>Quality</b></td><td>" + str(task.quality) + "</td></tr>"
         results += "<tr><td><b>QA uv-coverage</b></td><td>" + str(task.quality_json['uv-coverage']) + "</td></tr>"
         results += "<tr><td><b>QA sensitivity</b></td><td>" + str(task.quality_json['sensitivity']) + "</td></tr>"
         results += "<tr><td><b>QA observing-conditions</b></td><td>" + str(task.quality_json['observing-conditions']) + "</td></tr>"
diff --git a/atdb/taskdatabase/views.py b/atdb/taskdatabase/views.py
index b83a5c66..45284f9f 100644
--- a/atdb/taskdatabase/views.py
+++ b/atdb/taskdatabase/views.py
@@ -957,19 +957,14 @@ def TaskValidate(request, pk, quality, new_status, page=0):
     model = Task
     task = Task.objects.get(pk=pk)
 
-    # find all tasks with the same SAS_ID, and set this quality to all of the
+    # find all tasks with the same SAS_ID, and set this quality to all of them
     sas_id = task.sas_id
     tasks = Task.objects.filter(sas_id=sas_id)
     for task in tasks:
         if task.status == 'stored':
             task.quality = quality
             task.new_status = new_status
-            # task.save()
-
-    #task.new_status = new_status
-    #task.quality = quality
-
-    #task.save()
+            task.save()
 
     if page == 0:
         # redirect to details screen
-- 
GitLab