From c2403c95daa7cdafd2781f16553322043513f2e0 Mon Sep 17 00:00:00 2001
From: Vermaas <vermaas@astron.nl>
Date: Tue, 4 Apr 2023 13:49:58 +0200
Subject: [PATCH] handling review comments
---
atdb/taskdatabase/services/algorithms.py | 8 +++++++-
.../templates/taskdatabase/tasks/details_card.html | 2 +-
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/atdb/taskdatabase/services/algorithms.py b/atdb/taskdatabase/services/algorithms.py
index 8f05f408..db9d1dbd 100644
--- a/atdb/taskdatabase/services/algorithms.py
+++ b/atdb/taskdatabase/services/algorithms.py
@@ -708,6 +708,9 @@ def construct_inspectionplots(task,source='task_id'):
url = surl.replace(translation[0],translation[1])
results += '<tr><td><a href="' + url + '" target="_blank">'+ basename + '</a></td></tr>'
+# if basename.endswith('png'):
+# results += '<tr><td><a href="' + url + '" target="_blank"><img width="800" src="' + url + '" alt="' + basename + '"/></a></td></tr>'
+
plot_files.append(basename)
elif source == 'sas_id':
@@ -737,7 +740,10 @@ def construct_inspectionplots(task,source='task_id'):
url = surl.replace(translation[0], translation[1])
results += '<tr><td><a href="' + url + '" target="_blank">' + basename + '</a></td></tr>'
- #results += '<tr><td><a href="' + url + '" target="_blank">' + basename + '</a></td><td>'+str(plot['size'])+'</td></tr>'
+
+# if basename.endswith('png'):
+# results += '<tr><td><a href="' + url + '" target="_blank"><img width="800" src="' + url + '" alt="'+basename+'"/></a></td></tr>'
+
plot_files.append(plot_file)
except Exception as error:
diff --git a/atdb/taskdatabase/templates/taskdatabase/tasks/details_card.html b/atdb/taskdatabase/templates/taskdatabase/tasks/details_card.html
index 3c8cd644..54f6a784 100644
--- a/atdb/taskdatabase/templates/taskdatabase/tasks/details_card.html
+++ b/atdb/taskdatabase/templates/taskdatabase/tasks/details_card.html
@@ -5,7 +5,7 @@
<table class="table table-striped">
<tbody>
<tr><td><b>id</b></td><td><a href="{% url 'task-detail-view-api' task.pk %}" target="_blank">{{ task.id }} </a></td></tr>
- <tr><td><b>slurm jobs</b></td><td><a href="{% url 'job-list-view-api' %}?task_id={{ task.id }}" {{ task.id }} target="_blank">{{ task.id }} </a></td></tr>
+ <tr><td><b>slurm jobs</b></td><td><a href="{% url 'job-list-view-api' %}?task_id={{ task.id }}" {{ task.id }} target="_blank">jobs for task {{ task.id }} </a></td></tr>
<tr><td><b>priority</b></td><td>
{% if user.is_authenticated %}
--
GitLab