From 1de5f21cfbddb98629d78ed1ac362e320e31fbbb Mon Sep 17 00:00:00 2001
From: Vermaas <vermaas@astron.nl>
Date: Fri, 23 Jun 2023 11:30:02 +0200
Subject: [PATCH] bugfix in algorithm (poor was never reached)

---
 atdb/taskdatabase/models.py | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/atdb/taskdatabase/models.py b/atdb/taskdatabase/models.py
index 333f671b..cde087b7 100644
--- a/atdb/taskdatabase/models.py
+++ b/atdb/taskdatabase/models.py
@@ -106,9 +106,10 @@ def calculate_qualities(task):
                 rfi_percent = int(record['rfi_percent'])
                 if rfi_percent > 0:
                     quality = "good"
-                    if rfi_percent > quality_thresholds['moderate']:
+                    if (rfi_percent >= quality_thresholds['moderate'] and
+                            rfi_percent <= quality_thresholds['poor'])  :
                         quality = "moderate"
-                    elif rfi_percent > quality_thresholds['poor']:
+                    else:
                         quality = "poor"
             return quality
 
-- 
GitLab