radler merge requestshttps://git.astron.nl/RD/radler/-/merge_requests2022-08-05T08:11:19Zhttps://git.astron.nl/RD/radler/-/merge_requests/81Fix shifted source lists2022-08-05T08:11:19ZAndre OffringaFix shifted source listsSee https://gitlab.com/aroffringa/wsclean/-/issues/98 for the issue
The necessary WSClean changes are in https://gitlab.com/aroffringa/wsclean/-/merge_requests/448 , which also adds a test case that fails before the fix.See https://gitlab.com/aroffringa/wsclean/-/issues/98 for the issue
The necessary WSClean changes are in https://gitlab.com/aroffringa/wsclean/-/merge_requests/448 , which also adds a test case that fails before the fix.Andre OffringaAndre Offringahttps://git.astron.nl/RD/radler/-/merge_requests/82AST-959 Use new ImageAccessor API2022-08-11T13:46:34ZMaik NijhuisAST-959 Use new ImageAccessor APIMaik NijhuisMaik Nijhuishttps://git.astron.nl/RD/radler/-/merge_requests/83AST-960 Refactor PSF usage in Radler2022-08-10T07:56:47ZMark de WeverAST-960 Refactor PSF usage in RadlerOriginally every PSF assessor has its own offset. During the changes of
ticket AST-960 it was discovered the PSFs for the different channels
need to have the same PSF. This means the PSF offsets can be stored in
the WorkTable.
When no d...Originally every PSF assessor has its own offset. During the changes of
ticket AST-960 it was discovered the PSFs for the different channels
need to have the same PSF. This means the PSF offsets can be stored in
the WorkTable.
When no direction dependent PSF is used there's no need to store any
offset entries in the WorkTable.
Without this change it's quite hard to implement AST-960. The image
accessors of the PSF are converted to images in Radler's Perform step.
This meant the PSF offsets needed to be "attached" to the images, by
storing them in the WorkTable they can be passed as a function argument.
Closes AST-960Mark de WeverMark de Weverhttps://git.astron.nl/RD/radler/-/merge_requests/84AST-960 Select the correct PSF2022-08-12T06:19:07ZMark de WeverAST-960 Select the correct PSFThe change has no tests they will be added in AST-961
Closes AST-960The change has no tests they will be added in AST-961
Closes AST-960Mark de WeverMark de Weverhttps://git.astron.nl/RD/radler/-/merge_requests/85Make license headers equal2022-08-11T13:57:58ZMaik NijhuisMake license headers equal- Since Radler has the LGPL-3.0 license, files shouldn't have different license headers.
- Since Radler was derived from WSClean, it should have the same copyright in the documentation as WSClean.- Since Radler has the LGPL-3.0 license, files shouldn't have different license headers.
- Since Radler was derived from WSClean, it should have the same copyright in the documentation as WSClean.Maik NijhuisMaik Nijhuishttps://git.astron.nl/RD/radler/-/merge_requests/86AST-959 Test ImageAccessors2022-08-12T14:35:51ZMaik NijhuisAST-959 Test ImageAccessorsAdd tests for the LoadOnlyImageAccessor and LoadAndStoreImageAccessorAdd tests for the LoadOnlyImageAccessor and LoadAndStoreImageAccessorMaik NijhuisMaik Nijhuishttps://git.astron.nl/RD/radler/-/merge_requests/87AST-959 Resize psf when needed2022-08-16T07:31:43ZMaik NijhuisAST-959 Resize psf when neededMaik NijhuisMaik Nijhuishttps://git.astron.nl/RD/radler/-/merge_requests/88AST-978 Only use utils::LoadOnlyImageAccessor2022-08-12T08:58:08ZMaik NijhuisAST-978 Only use utils::LoadOnlyImageAccessorRemove test::LoadOnlyImageAccessor
Ensure that the provided Images remain in scope in the test, which is needed for utils::LoadOnlyImageAccessor.Remove test::LoadOnlyImageAccessor
Ensure that the provided Images remain in scope in the test, which is needed for utils::LoadOnlyImageAccessor.Maik NijhuisMaik Nijhuishttps://git.astron.nl/RD/radler/-/merge_requests/89Ast 961 add test to check that the closest PSF is selected2022-08-16T08:11:50ZChiara SalvoniAst 961 add test to check that the closest PSF is selectedAdds a Python test which checks that during deconvolution, the PSF closest to the point source is chosen.Adds a Python test which checks that during deconvolution, the PSF closest to the point source is chosen.Chiara SalvoniChiara Salvonihttps://git.astron.nl/RD/radler/-/merge_requests/90AST-959 Extend PSF validation2022-08-19T08:46:32ZMaik NijhuisAST-959 Extend PSF validation- Validate that the PSF sizes are non-zero.
- Validate that the PSF sizes are equal in all PSF accessor lists.
- Only require PSF accessor lists for the first entry of each group.- Validate that the PSF sizes are non-zero.
- Validate that the PSF sizes are equal in all PSF accessor lists.
- Only require PSF accessor lists for the first entry of each group.Maik NijhuisMaik Nijhuishttps://git.astron.nl/RD/radler/-/merge_requests/91AST-985 Test ImageSet::LoadAndAveragePsfs2022-08-19T11:20:25ZMaik NijhuisAST-985 Test ImageSet::LoadAndAveragePsfsMaik NijhuisMaik Nijhuishttps://git.astron.nl/RD/radler/-/merge_requests/92AST-490 Format python files using black2022-08-29T11:42:23ZMaik NijhuisAST-490 Format python files using blackClean up ubuntu-20 image. Use ubuntu-22 for formatting and linting.Clean up ubuntu-20 image. Use ubuntu-22 for formatting and linting.Maik NijhuisMaik Nijhuishttps://git.astron.nl/RD/radler/-/merge_requests/93Rename l,m shift variables2022-10-04T12:04:16ZAndre OffringaRename l,m shift variablesAndre OffringaAndre Offringahttps://git.astron.nl/RD/radler/-/merge_requests/94AST-945 Protect embedded python code by mutex2022-09-29T07:34:35ZBas van der TolAST-945 Protect embedded python code by mutexEmbedded python code can not be run multi threaded.
This MR protects the execution of embedded python by a mutex.
An alternative would be to use a Global Interpreter Lock (GIL), but that caused a dead lock in parallel deconvolution.Embedded python code can not be run multi threaded.
This MR protects the execution of embedded python by a mutex.
An alternative would be to use a Global Interpreter Lock (GIL), but that caused a dead lock in parallel deconvolution.Bas van der TolBas van der Tolhttps://git.astron.nl/RD/radler/-/merge_requests/95Update docstring for write_sources, add default2022-10-04T18:34:41ZTammo Jan DijkemaUpdate docstring for write_sources, add defaultThe docstring for `write_sources` did not match the function interface. Also, I think l_shift and m_shift should be optional, since they're 0.0 almost always. Adding a default makes a previous demo run again with the latest version.The docstring for `write_sources` did not match the function interface. Also, I think l_shift and m_shift should be optional, since they're 0.0 almost always. Adding a default makes a previous demo run again with the latest version.https://git.astron.nl/RD/radler/-/merge_requests/96Refactoring to identify iteration number issue2022-12-08T18:02:02ZAndre OffringaRefactoring to identify iteration number issueIt did turn out the issue was in WSClean and not in Radler :laughing: . Issue is solved here: https://gitlab.com/aroffringa/wsclean/-/merge_requests/487It did turn out the issue was in WSClean and not in Radler :laughing: . Issue is solved here: https://gitlab.com/aroffringa/wsclean/-/merge_requests/487Andre OffringaAndre Offringahttps://git.astron.nl/RD/radler/-/merge_requests/97Draft: AST-1102 Use Nanobind instead of Pybind112022-12-09T11:42:18ZMaik NijhuisDraft: AST-1102 Use Nanobind instead of Pybind11This MR is the result of investigating using Nanobind instead of Pybind11. It should not be merged yet (December 2022), since the conclusion is that we should stick with the more stable Pybind11 for now.
Reviewers should thus focus on r...This MR is the result of investigating using Nanobind instead of Pybind11. It should not be merged yet (December 2022), since the conclusion is that we should stick with the more stable Pybind11 for now.
Reviewers should thus focus on remaining questions about Nanobind instead of on merging this MR.Maik NijhuisMaik Nijhuishttps://git.astron.nl/RD/radler/-/merge_requests/98Add a mask channel index to fix WSClean !3522023-01-25T09:01:15ZAndre OffringaAdd a mask channel index to fix WSClean !352Non-joined deconvolution with a fits cube no longer worked in WSClean because of changes
in https://gitlab.com/aroffringa/wsclean/-/merge_requests/352.
An integration test for this is added in https://gitlab.com/aroffringa/wsclean/-/merg...Non-joined deconvolution with a fits cube no longer worked in WSClean because of changes
in https://gitlab.com/aroffringa/wsclean/-/merge_requests/352.
An integration test for this is added in https://gitlab.com/aroffringa/wsclean/-/merge_requests/503.
In a later MR, the new variable should be exposed in the Python API.Andre OffringaAndre Offringahttps://git.astron.nl/RD/radler/-/merge_requests/99CWG-34 Add ABI breakage CI test2023-06-01T07:30:49ZMark de WeverCWG-34 Add ABI breakage CI testCloses CWG-34Closes CWG-34Mark de WeverMark de Weverhttps://git.astron.nl/RD/radler/-/merge_requests/100Higher order forced constraining2023-02-03T11:08:51ZAndre OffringaHigher order forced constrainingAndre OffringaAndre Offringa